-
Notifications
You must be signed in to change notification settings - Fork 11
Update deprecated github actions #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: thepetk <thepetk@gmail.com>
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
|
I've tried to update go to 1.19 but I see the issue with ODC is that the image https://quay.io/repository/coreos/tectonic-console-builder?tab=tags&tag=v24 used by the workflows failing needs to have a more updated go version. |
|
fixes devfile/api#1249 |
Signed-off-by: thepetk <thepetk@gmail.com>
|
@kim-tsao I've updated the version of |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, kim-tsao, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
This PR updates specific github actions to latest version in order to use NodeJS 16 and not NodeJS 12.
The updated github actions are:
actions/checkout@v2>actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3actions/setup-go@v2>actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0What issues does this PR fix or reference?
fixes devfile/api#1229
fixes devfile/api#1249
Is your PR tested? Consider putting some instruction how to test your changes
The PR simply updates the
gotest.yamlworkflow in order to use the latest version of two github actions.