Jsl yoon/update go1.23 #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

JslYoon wants to merge 2 commits into main from JslYoon/updateGo1.24

Contributor

JslYoon commented Aug 19, 2025

Description of Changes

revert the changes from go 1.24 to go 1.23

Related Issue(s)

devfile/api#1710


          changing ubi9 go models

8497d24

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

JslYoon requested a review from michael-valdron

August 19, 2025 14:45

JslYoon self-assigned this

openshift-ci bot requested a review from Jdubrick

August 19, 2025 14:45

openshift-ci bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JslYoon
Once this PR has been reviewed and has the lgtm label, please assign thepetk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-advanced-security bot found potential problems

View reviewed changes

.ci/Dockerfile

    
              # See the License for the specific language governing permissions and

              # limitations under the License.

              FROM golang:1.24-alpine@sha256:daae04ebad0c21149979cd8e9db38f565ecefd8547cf4a591240dc1972cf1399 AS builder

              FROM golang:1.23-alpine AS builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 5: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating golang:1.23-alpine to golang:1.23-alpine@sha256:383395b794dffa5b53012a212365d40c8e37109a626ca30d6151c8348d380b5f
Click Remediation section below for further remediation help

index/server/Dockerfile Fixed Show fixed Hide fixed

oci-registry/Dockerfile Fixed Show fixed Hide fixed

tests/integration/Dockerfile Fixed Show fixed Hide fixed

JslYoon force-pushed the JslYoon/updateGo1.24 branch from c54fa97 to 292252b Compare

August 19, 2025 14:55


          go 1.23

7dd0d76

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

JslYoon force-pushed the JslYoon/updateGo1.24 branch from 292252b to 7dd0d76 Compare

August 19, 2025 19:22

github-advanced-security bot found potential problems

View reviewed changes

tests/integration/vendor/github.com/docker/distribution/Dockerfile

    
              ARG ALPINE_VERSION=3.18

              ARG XX_VERSION=1.2.1

              FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library test

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue

tests/integration/vendor/github.com/docker/distribution/Dockerfile

    
              ARG XX_VERSION=1.2.1

              FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx

              FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS base

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library test

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue

tests/integration/vendor/github.com/docker/distribution/Dockerfile

    
              ENV CGO_ENABLED=0

              WORKDIR /go/src/github.com/docker/distribution

              FROM base AS version

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library test

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue

tests/integration/vendor/github.com/docker/distribution/Dockerfile

    
                echo "-X ${PKG}/version.Version=${VERSION#v} -X ${PKG}/version.Revision=${REVISION} -X ${PKG}/version.Package=${PKG}" | tee /tmp/.ldflags; \

                echo -n "${VERSION}" | tee /tmp/.version;

              FROM base AS build

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library test

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue

tests/integration/vendor/github.com/docker/distribution/Dockerfile

    
              FROM scratch AS binary

              COPY --from=build /usr/bin/registry /

              FROM base AS releaser

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library test

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue

tests/integration/vendor/github.com/json-iterator/go/build.sh

    
                  ln -s $PWD /tmp/build-golang/src/github.com/json-iterator/go

              fi

              export GOPATH=/tmp/build-golang

              go get -u github.com/golang/dep/cmd/dep

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library test

score is 5: goCommand not pinned by hash
Click Remediation section below to solve this issue

tests/integration/vendor/github.com/nxadm/tail/Dockerfile

    
            @@ -0,0 +1,19 @@
          
              FROM golang

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library test

score is 5: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating golang to golang@sha256:91e2cd436f7adbfad0a0cbb7bf8502fa863ed8461414ceebe36c6304731e0fd9
Click Remediation section below for further remediation help

tests/integration/vendor/github.com/nxadm/tail/Dockerfile

    
              ADD . $GOPATH/src/github.com/nxadm/tail/

              # expecting to fetch dependencies successfully.

              RUN go get -v github.com/nxadm/tail

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library test

score is 5: goCommand not pinned by hash
Click Remediation section below to solve this issue

tests/integration/vendor/github.com/nxadm/tail/Dockerfile

    
              RUN go test -v github.com/nxadm/tail

              # expecting to install successfully

              RUN go install -v github.com/nxadm/tail

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library test

score is 5: goCommand not pinned by hash
Click Remediation section below to solve this issue

tests/integration/vendor/github.com/nxadm/tail/Dockerfile

    
              # expecting to install successfully

              RUN go install -v github.com/nxadm/tail

              RUN go install -v github.com/nxadm/tail/cmd/gotail

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library test

score is 5: goCommand not pinned by hash
Click Remediation section below to solve this issue

Member

michael-valdron commented Aug 19, 2025

@JslYoon found a workable solution for openshift/release#68063 to move forward with Go 1.24.

michael-valdron closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet