Skip to content

Conversation

@JslYoon
Copy link
Contributor

@JslYoon JslYoon commented Aug 12, 2025

Bumping up go version of registry and registry-operator checks to 1.24 per some CI tests are failing:
devfile/registry#626

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

Hi @JslYoon. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gabemontero
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2025
@michael-valdron
Copy link
Member

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm looks like there is no golang-1.24 tag on the CI image 🤔

Let me investigate if the image or tag has changed.

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
@JslYoon JslYoon force-pushed the JslYoon-update-go branch from dcae0db to 9317882 Compare August 12, 2025 19:26
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 15, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@JslYoon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 15, 2025

Created issue devfile/api/#1748

@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 15, 2025

/test all

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 18, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@JslYoon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 19, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@JslYoon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
@JslYoon JslYoon force-pushed the JslYoon-update-go branch from 88bcd01 to d113c17 Compare August 19, 2025 20:35
@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 19, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@JslYoon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@JslYoon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-devfile-registry-operator-main-v4.18-images devfile/registry-operator presubmit Ci-operator config changed
pull-ci-devfile-registry-operator-main-v4.18-registry-operator-integration-test devfile/registry-operator presubmit Ci-operator config changed
pull-ci-devfile-registry-main-v4.16-images devfile/registry presubmit Ci-operator config changed
pull-ci-devfile-registry-main-v4.16-registry-test devfile/registry presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@michael-valdron
Copy link
Member

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 19, 2025
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JslYoon, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 51f18d4 into openshift:master Aug 19, 2025
14 of 17 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

@JslYoon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/devfile/registry/main/v4.16-images d113c17 link unknown /pj-rehearse pull-ci-devfile-registry-main-v4.16-images
ci/rehearse/devfile/registry/main/v4.16-registry-test d113c17 link unknown /pj-rehearse pull-ci-devfile-registry-main-v4.16-registry-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JslYoon JslYoon deleted the JslYoon-update-go branch August 20, 2025 13:55
tbuskey pushed a commit to tbuskey/release that referenced this pull request Aug 26, 2025
* Bump up devfile registry checks to use go 1.24

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

* trying out external mirrored image

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

* ocp 4.20 test

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

* trying out new image

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

---------

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
Co-authored-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
etmurasaki pushed a commit to etmurasaki/release that referenced this pull request Sep 3, 2025
* Bump up devfile registry checks to use go 1.24

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

* trying out external mirrored image

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

* ocp 4.20 test

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

* trying out new image

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

---------

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
Co-authored-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 9, 2025
* Bump up devfile registry checks to use go 1.24

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

* trying out external mirrored image

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

* ocp 4.20 test

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

* trying out new image

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>

---------

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
Co-authored-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants