-
Notifications
You must be signed in to change notification settings - Fork 2k
Bump up devfile registry checks to use go 1.24 #68063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up devfile registry checks to use go 1.24 #68063
Conversation
|
Hi @JslYoon. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/pj-rehearse auto-ack |
|
@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
michael-valdron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm looks like there is no golang-1.24 tag on the CI image 🤔
Let me investigate if the image or tag has changed.
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
dcae0db to
9317882
Compare
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
|
/pj-rehearse auto-ack |
|
@JslYoon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Created issue devfile/api/#1748 |
|
/test all |
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
|
/pj-rehearse |
|
@JslYoon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@JslYoon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
88bcd01 to
d113c17
Compare
|
/pj-rehearse auto-ack |
|
@JslYoon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
michael-valdron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JslYoon, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
51f18d4
into
openshift:master
|
@JslYoon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
* Bump up devfile registry checks to use go 1.24 Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> * trying out external mirrored image Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> * ocp 4.20 test Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> * trying out new image Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> --------- Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> Co-authored-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
* Bump up devfile registry checks to use go 1.24 Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> * trying out external mirrored image Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> * ocp 4.20 test Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> * trying out new image Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> --------- Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> Co-authored-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
* Bump up devfile registry checks to use go 1.24 Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> * trying out external mirrored image Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> * ocp 4.20 test Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> * trying out new image Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> --------- Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb> Co-authored-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
Bumping up go version of registry and registry-operator checks to 1.24 per some CI tests are failing:
devfile/registry#626