Skip to content

new icon: vitejs (original, original wordmark) #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AcmeGamers wants to merge 5 commits into from
Closed

new icon: vitejs (original, original wordmark) #1252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7a43b9
Merge pull request #1084 from devicons/develop
amacado Mar 22, 2022
619c806
bump npm version to v2.15.1
amacado Mar 22, 2022
1119b9f
Merge pull request #1085 from devicons/draft-release
Thomas-Boi Mar 23, 2022
5da3fb1
vitejs
AcmeGamers Jul 3, 2022
c1220c0
Add files via upload
AcmeGamers Jul 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions devicon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5776,6 +5776,22 @@
},
"color": "#294172",
"aliases": []
}

},
{
"name": "vitejs",
Copy link
Collaborator

@Snailedlt Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "vitejs",
"name": "vitejs",
"altnames": []

"tags": ["react", "compiler", "esbuild"],
Copy link
Collaborator

@Snailedlt Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those aren't really relevant for vite, so here's some other suggestions

Suggested change
"tags": ["react", "compiler", "esbuild"],
"tags": [
"tooling",
"buildtool",
"bundler",
"javascript",
"js",
],

"versions": {
"svg": [
"original",
"original-wordmark",
],
"font": ["original"]
Copy link
Collaborator

@Snailedlt Snailedlt Jul 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"font": ["original"]
"font": [
"original",
"original-wordmark"
]

},
"color": "#4FBFFF",
"aliases": [
{
"base": "original"
Copy link
Collaborator

@Snailedlt Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also add an alias here.

Suggested change
"base": "original"
"base": "original"
"alias": "plain"

I suggest you take a look at Example-of-Submitting-Icons-to-the-Repository and Updating the devicon.json to see why it should be like this.

}
]
}
]
Binary file added icons/vitejs/vite-original-wordmark.eps
View file
Open in desktop
Binary file not shown.
27 changes: 27 additions & 0 deletions icons/vitejs/vite-original-wordmark.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added icons/vitejs/vite-original.eps
View file
Open in desktop
Binary file not shown.
23 changes: 23 additions & 0 deletions icons/vitejs/vite-original.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "devicon",
"version": "2.15.0",
"version": "2.15.1",
Copy link
Collaborator

@Snailedlt Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should reverse all the changes in package.json since they are not relevant for icon requests

"description": "Programming related icons collection",
"main": "devicon.min.css",
"scripts": {
Expand Down