new icon: vitejs (original, original wordmark) #1252

AcmeGamers · 2022-07-03T03:04:08Z

Double check these details before you open a PR

[ ✔ ] PR does not match another non-stale PR currently opened
[ ✔ ] PR name matches the format new icon: Icon name (versions separated by comma). More details here
[ ✔ ] PR's base is the develop branch.
[ ✔ ] Your icons are inside a folder as seen here
[ ] SVG matches the standards laid out here
[ ✔ ] A new object is added in the devicon.json file as seen here

This PR closes NONE
This PR closes #1053

Link to prove your SVG is correct and up-to-date.

https://vitejs.dev/

Fix issue with npm publish script

Build preparation for release v2.15.1

kilianpaquier · 2022-07-03T10:28:50Z

Hello @AcmeGamers, I reviewed your PR #1253, can you follow the recommandations and standards for this PR too ?

AcmeGamers · 2022-07-05T06:42:55Z

Hello @AcmeGamers, I reviewed your PR #1253, can you follow the recommandations and standards for this PR too ?

Onto it :D, and really thanks for helping out with the previous ones

Snailedlt

In addition to all the changes suggested below, you can also remove the .eps files.
A good start, but needs a bit of work before it's ready to be merged :)

Let us know if you need any more help

Snailedlt · 2022-07-25T21:48:11Z

icons/vitejs/vite-original-wordmark.svg

+<?xml version="1.0" encoding="utf-8"?>
+<!-- Generator: Adobe Illustrator 24.0.1, SVG Export Plug-In . SVG Version: 6.00 Build 0)  -->
+<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
+	 viewBox="0 0 271.6 113.8" style="enable-background:new 0 0 271.6 113.8;" xml:space="preserve">


Make sure the viewbox is 0 0 128 128 as explained in the SVG Standards

Snailedlt · 2022-07-25T21:48:47Z

icons/vitejs/vite-original.svg

+<?xml version="1.0" encoding="utf-8"?>
+<!-- Generator: Adobe Illustrator 24.0.1, SVG Export Plug-In . SVG Version: 6.00 Build 0)  -->
+<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
+	 viewBox="0 0 121.4 119.8" style="enable-background:new 0 0 121.4 119.8;" xml:space="preserve">


make sure the viewbox is 0 0 128 128 as explained in the SVG Standards

Snailedlt · 2022-07-25T21:51:42Z

devicon.json

+    },
+    {
+    "name": "vitejs",
+    "tags": ["react", "compiler", "esbuild"],


Those aren't really relevant for vite, so here's some other suggestions

Suggested change

"tags": ["react", "compiler", "esbuild"],

"tags": [

"tooling",

"buildtool",

"bundler",

"javascript",

"js",

],

Snailedlt · 2022-07-25T21:55:36Z

devicon.json

+    "color": "#4FBFFF",
+    "aliases": [
+      {
+        "base": "original"


You need to also add an alias here.

Suggested change

"base": "original"

"base": "original"

"alias": "plain"

I suggest you take a look at Example-of-Submitting-Icons-to-the-Repository and Updating the devicon.json to see why it should be like this.

Snailedlt · 2022-07-25T21:58:57Z

package.json

 {
  "name": "devicon",
-  "version": "2.15.0",
+  "version": "2.15.1",


You should reverse all the changes in package.json since they are not relevant for icon requests

Snailedlt · 2022-07-25T21:59:17Z

package-lock.json

 {
  "name": "devicon",
-  "version": "2.15.0",
+  "version": "2.15.1",


You should reverse all the changes in package-lock.json since they are not relevant for icon requests

Snailedlt · 2022-07-25T22:08:08Z

devicon.json

+	      "original", 
+	      "original-wordmark",
+      ],
+      "font": ["original"]


Suggested change

"font": ["original"]

"font": [

"original",

"original-wordmark"

]

Snailedlt · 2022-07-25T22:11:48Z

devicon.json

-
+    },
+    {
+    "name": "vitejs",


Suggested change

"name": "vitejs",

"name": "vitejs",

"altnames": []

Snailedlt · 2022-07-28T20:21:34Z

@AcmeGamers Please read and implement the changes listed above when you have time

Snailedlt · 2022-08-06T11:47:54Z

Let us know if you need any help with the PR :)

Snailedlt · 2022-10-26T09:04:54Z

Stale and replaced by #1473

amacado and others added 5 commits March 22, 2022 22:31

Merge pull request devicons#1084 from devicons/develop

e7a43b9

Fix issue with npm publish script

bump npm version to v2.15.1

619c806

Merge pull request devicons#1085 from devicons/draft-release

1119b9f

Build preparation for release v2.15.1

vitejs

5da3fb1

Add files via upload

c1220c0

Snailedlt requested changes Jul 25, 2022

View reviewed changes

Snailedlt reviewed Jul 25, 2022

View reviewed changes

devicon.json

},

{

"name": "vitejs",

Copy link

Collaborator

Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

"name": "vitejs",

"name": "vitejs",

"altnames": []

Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Jul 28, 2022

Snailedlt added the stale PRs that haven't had any activity for a while and old issues label Oct 1, 2022

kilianpaquier mentioned this pull request Oct 19, 2022

new icon: vitejs (original, plain) #1473

Merged

6 tasks

Snailedlt closed this Oct 26, 2022

-    "tags": ["react", "compiler", "esbuild"],
+    "tags": [
+        "tooling",
+        "buildtool",
+        "bundler",
+        "javascript",
+        "js",
+    ],

new icon: vitejs (original, original wordmark) #1252

new icon: vitejs (original, original wordmark) #1252

Uh oh!

Conversation

AcmeGamers commented Jul 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

Uh oh!

kilianpaquier commented Jul 3, 2022

Uh oh!

AcmeGamers commented Jul 5, 2022

Uh oh!

Snailedlt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

Snailedlt Jul 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Snailedlt Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

Snailedlt commented Jul 28, 2022

Uh oh!

Snailedlt commented Aug 6, 2022

Uh oh!

Snailedlt commented Oct 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AcmeGamers commented Jul 3, 2022 •

edited

Loading

Snailedlt left a comment •

edited

Loading

Snailedlt Jul 25, 2022 •

edited

Loading