Skip to content

new icon: vitejs (original, plain) #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Snailedlt merged 12 commits into from
Dec 4, 2022
Merged

new icon: vitejs (original, plain) #1473

Snailedlt merged 12 commits into from
Dec 4, 2022

Conversation

@kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Oct 19, 2022 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1053

This PR can be closed : #1252

Link to prove your SVG is correct and up-to-date.

https://vitejs.dev/

@kilianpaquier kilianpaquier changed the title Vitejs new icon: vitejs (original, plain) Oct 19, 2022
@Snailedlt Snailedlt mentioned this pull request Oct 26, 2022
Closed
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Oct 30, 2022
Snailedlt
Snailedlt requested changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up this PR, looks good for the most part, just a few things missing

@kilianpaquier @Snailedlt
vitejs | applied suggestion from code review
a5fafac 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
kilianpaquier
kilianpaquier commented Oct 31, 2022
View reviewed changes
@Snailedlt Snailedlt added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

Beautiful 😘👌
Thank you for the quick fizes whcih made reviewing a breeze, and ofc thank you for the contribution! 💯

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2022
lunatic-fox
lunatic-fox requested changes Nov 8, 2022
View reviewed changes
Snailedlt
Snailedlt previously approved these changes Nov 29, 2022
View reviewed changes
lunatic-fox
lunatic-fox approved these changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons optimized and conflicts resolved!

Approved! ✔
Thank you for this contribution! 🚀

@lunatic-fox lunatic-fox added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@lunatic-fox lunatic-fox requested a review from Snailedlt December 3, 2022 14:21
@Snailedlt Snailedlt merged commit 800cd5f into devicons:develop Dec 4, 2022
@kilianpaquier kilianpaquier deleted the vitejs branch January 3, 2023 14:29
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@kilianpaquier @amacado
@Thomas-Boi @AcmeGamers @Snailedlt @lunatic-fox
new icon: vitejs (original, plain) (devicons#1473)
84c60d5 
* bump npm version to v2.15.1

* vitejs

* Add files via upload

* vitejs | reviewed icons for standards

* vitejs | applied suggestion from code review

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update devicon.json

* Update devicon.json

* Optimize icons

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Amacado <clemens.bastian@gmail.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Co-authored-by: Acme Gamers <52010365+AcmeGamers@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

Assignees

No one assigned

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kilianpaquier @Snailedlt @lunatic-fox @amacado @Thomas-Boi @AcmeGamers