-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: githubcodespaces (original, plain) #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
| }, | ||
| { | ||
| "name": "gitlab", | ||
| "altnames": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lunatic-fox! :) I hope you’re doing well! :) I’m thinking it would be beneficial to change the label from plural to singular (“altnames” —> “altname”). Easier to read. As far the alt name itself, call it “gitlab”. It’ll be familiar to coders with disabilities who use this tool. If you have any questions or feedback on my review (this my first one for this repo. Woo! 🎉🎊), don’t hesitate to tag me in this comment section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there @CBID2! I hope you're doing well too!
Change altnames to altname would break the structure and backwards compatibility of devicon.json, because it's a property key.
altnames is a array of strings property key, in other words, it works like a title of a list, for instance: "items", "groceries list", "tasks". They're usually in plural, even when they're empty.
gitlab doesn't have any alternative name: "altnames": []
I recently made a feature request to make Intellisense work on devicon.json, as many users use VS Code or GitHub Codespaces to edit the code, that way you can create a new entry object easily and have some description of each property when you hover over them.
I hope I got everything right!
Wish for the best!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that idea @lunatic-fox! :) I use VS Code , so this would be helpful.
| }, | ||
| { | ||
| "name": "gitlab", | ||
| "altnames": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that idea @lunatic-fox! :) I use VS Code , so this would be helpful.
|
@lunatic-fox conflicts need to be solved here :) |
|
Something went really wrong. I'll be redoing this PR. |





Double check these details before you open a PR
- PR does not match another non-stale PR currently opened
- PR name matches the format new icon: Icon name (versions separated by comma). More details here
- PR's base is the
- Your icons are inside a folder as seen here
- SVG matches the standards laid out here
- A new object is added in the
This PR closes #1425developbranch.devicon.jsonfile as seen hereLink to prove your SVG is correct and up-to-date.
https://github.githubassets.com/images/modules/site/codespaces/codespaces-logo.svg
https://github.com/favicons/favicon-codespaces.svg