Skip to content

Conversation

@lunatic-fox
Copy link
Contributor

@lunatic-fox lunatic-fox commented Oct 12, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here
This PR closes #1425

Link to prove your SVG is correct and up-to-date.

https://github.githubassets.com/images/modules/site/codespaces/codespaces-logo.svg
https://github.com/favicons/favicon-codespaces.svg

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Oct 14, 2022
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 14, 2022
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Oct 14, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

@Snailedlt Snailedlt requested a review from Panquesito7 October 14, 2022 18:24
},
{
"name": "gitlab",
"altnames": [],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lunatic-fox! :) I hope you’re doing well! :) I’m thinking it would be beneficial to change the label from plural to singular (“altnames” —> “altname”). Easier to read. As far the alt name itself, call it “gitlab”. It’ll be familiar to coders with disabilities who use this tool. If you have any questions or feedback on my review (this my first one for this repo. Woo! 🎉🎊), don’t hesitate to tag me in this comment section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there @CBID2! I hope you're doing well too!

Change altnames to altname would break the structure and backwards compatibility of devicon.json, because it's a property key.

altnames is a array of strings property key, in other words, it works like a title of a list, for instance: "items", "groceries list", "tasks". They're usually in plural, even when they're empty.

gitlab doesn't have any alternative name: "altnames": []

I recently made a feature request to make Intellisense work on devicon.json, as many users use VS Code or GitHub Codespaces to edit the code, that way you can create a new entry object easily and have some description of each property when you hover over them.

I hope I got everything right!
Wish for the best!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea @lunatic-fox! :) I use VS Code , so this would be helpful.

@Snailedlt Snailedlt requested a review from CBID2 October 29, 2022 23:14
CBID2
CBID2 previously approved these changes Oct 29, 2022
},
{
"name": "gitlab",
"altnames": [],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea @lunatic-fox! :) I use VS Code , so this would be helpful.

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2022
@Snailedlt
Copy link
Collaborator

@lunatic-fox conflicts need to be solved here :)

@lunatic-fox lunatic-fox dismissed stale reviews from CBID2 and Snailedlt via 2543e58 December 10, 2022 11:37
@lunatic-fox
Copy link
Contributor Author

Something went really wrong. I'll be redoing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants