Skip to content

new icon: githubcodespaces (original, plain) #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lunatic-fox wants to merge 10 commits into from
Closed

new icon: githubcodespaces (original, plain) #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
35ab523
Add Ren'Py
lunatic-fox Sep 28, 2022
71d9c50
Update devicon.json
lunatic-fox Sep 30, 2022
032511e
Merge branch 'devicons:develop' into develop
lunatic-fox Oct 11, 2022
804609d
Merge branch 'devicons:develop' into develop
lunatic-fox Oct 12, 2022
5f4f954
Add GitHub Codespaces
lunatic-fox Oct 12, 2022
a2d7297
Update devicon.json
lunatic-fox Oct 14, 2022
901f1b5
Update devicon.json
lunatic-fox Oct 14, 2022
2543e58
Resolve conflict in devicon.json
lunatic-fox Dec 10, 2022
26ffb55
Resolve `devicon.json`
lunatic-fox Dec 10, 2022
4d90738
Merge branch 'develop' into add_githubcodespaces
lunatic-fox Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 76 additions & 0 deletions devicon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3074,6 +3074,30 @@
"color": "#2088FF",
"aliases": []
},
{
"name": "githubcodespaces",
"altnames": [
"GitHub Codespaces"
],
"tags": [
"development",
"remote-development",
"editor",
"browser",
"cloud"
],
"versions": {
"svg": [
"original",
"plain"
],
"font": [
"plain"
]
},
"color": "#24292e",
"aliases": []
},
{
"name": "gitlab",
"altnames": [],
Copy link

@CBID2 CBID2 Oct 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lunatic-fox! :) I hope you’re doing well! :) I’m thinking it would be beneficial to change the label from plural to singular (“altnames” —> “altname”). Easier to read. As far the alt name itself, call it “gitlab”. It’ll be familiar to coders with disabilities who use this tool. If you have any questions or feedback on my review (this my first one for this repo. Woo! 🎉🎊), don’t hesitate to tag me in this comment section.

Copy link
Contributor Author

@lunatic-fox lunatic-fox Oct 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there @CBID2! I hope you're doing well too!

Change altnames to altname would break the structure and backwards compatibility of devicon.json, because it's a property key.

altnames is a array of strings property key, in other words, it works like a title of a list, for instance: "items", "groceries list", "tasks". They're usually in plural, even when they're empty.

gitlab doesn't have any alternative name: "altnames": []

I recently made a feature request to make Intellisense work on devicon.json, as many users use VS Code or GitHub Codespaces to edit the code, that way you can create a new entry object easily and have some description of each property when you hover over them.

I hope I got everything right!
Wish for the best!

Copy link

@CBID2 CBID2 Oct 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea @lunatic-fox! :) I use VS Code , so this would be helpful.

Expand Down Expand Up @@ -4220,6 +4244,37 @@
}
]
},
{
"name": "julia",
"altnames": [
"julialang"
],
"tags": [
"programming",
"language"
],
"versions": {
"svg": [
"original",
"original-wordmark"
],
"font": [
"original",
"original-wordmark"
]
},
"color": "#5f7389",
"aliases": [
{
"base": "original",
"alias": "plain"
},
{
"base": "original-wordmark",
"alias": "plain-wordmark"
}
]
},
{
"name": "julia",
"altnames": [
Expand Down Expand Up @@ -7974,6 +8029,27 @@
"color": "#85ea2d",
"aliases": []
},
{
"name": "swift",
"altnames": [],
"tags": [
"language"
],
"versions": {
"svg": [
"original",
"original-wordmark",
"plain",
"plain-wordmark"
],
"font": [
"plain",
"plain-wordmark"
]
},
"color": "#85ea2d",
"aliases": []
},
{
"name": "swift",
"altnames": [],
Expand Down
20 changes: 20 additions & 0 deletions icons/githubcodespaces/githubcodespaces-original.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions icons/githubcodespaces/githubcodespaces-plain.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.