-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Update many of the actions to their latest version #1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| jobs: | ||
| stale: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-latestlatest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| runs-on: ubuntu-latestlatest | |
| runs-on: ubuntu-latest |
|
I've tested a few workflows on my fork and they seem to be working fine. |
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Statically it looks good, and I trust you tested all of the workflows properly :)
Thanks for the contributions @Panquesito7 🙇
Thank you for reviewing! In case there's anything wrong, we can always revert this PR. 😉 |
lunatic-fox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
Just one suggestion about dawidd6/action-download-artifact action version and @Snailedlt suggestion on .github/drafts/stale.yml.
|
|
||
| - name: Download workflow artifact | ||
| uses: dawidd6/action-download-artifact@v2.11.0 | ||
| uses: dawidd6/action-download-artifact@v2.26.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a recently update to that action.
| uses: dawidd6/action-download-artifact@v2.26.1 | |
| uses: dawidd6/action-download-artifact@v2.27.0 |
|
|
||
| - name: Download workflow artifact | ||
| uses: dawidd6/action-download-artifact@v2.11.0 | ||
| uses: dawidd6/action-download-artifact@v2.26.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| uses: dawidd6/action-download-artifact@v2.26.1 | |
| uses: dawidd6/action-download-artifact@v2.27.0 |
|
Weird, GitHub did not notify me about the reviews 👀 let me update those. Thanks, @lunatic-fox. 🙂 |
| post_screenshots_in_comment: | ||
| name: Post the screenshot | ||
| runs-on: ubuntu-18.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠ This change will take effect when this commit is merged to master, as for now this action will be loading indefinitely to find a ubuntu-18.04 machine.
* Update many of the actions to their latest version * Fix CodeQL action * Use the latest version for all images * Whoops * Use Ubuntu for the Peek Icons workflow * Fix Peek Icons action * Remove token * chore: apply suggestions from code review Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> --------- Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Things added/changed: