Skip to content

Conversation

@Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Apr 12, 2023

Things added/changed:

  • Update many of the actions to their latest version.

@Panquesito7 Panquesito7 added the devops Devops/automation related enhancements label Apr 12, 2023
jobs:
stale:
runs-on: ubuntu-latest
runs-on: ubuntu-latestlatest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: ubuntu-latestlatest
runs-on: ubuntu-latest

@Panquesito7
Copy link
Member Author

I've tested a few workflows on my fork and they seem to be working fine.
Please check again and make sure everything's correct. Thanks. 🙂

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Statically it looks good, and I trust you tested all of the workflows properly :)

Thanks for the contributions @Panquesito7 🙇

@Panquesito7
Copy link
Member Author

Statically it looks good, and I trust you tested all of the workflows properly :)

Thank you for reviewing! In case there's anything wrong, we can always revert this PR. 😉

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀
Just one suggestion about dawidd6/action-download-artifact action version and @Snailedlt suggestion on .github/drafts/stale.yml.


- name: Download workflow artifact
uses: dawidd6/action-download-artifact@v2.11.0
uses: dawidd6/action-download-artifact@v2.26.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a recently update to that action.

Suggested change
uses: dawidd6/action-download-artifact@v2.26.1
uses: dawidd6/action-download-artifact@v2.27.0


- name: Download workflow artifact
uses: dawidd6/action-download-artifact@v2.11.0
uses: dawidd6/action-download-artifact@v2.26.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: dawidd6/action-download-artifact@v2.26.1
uses: dawidd6/action-download-artifact@v2.27.0

@Panquesito7 Panquesito7 merged commit 2b9faad into develop Apr 28, 2023
@Panquesito7
Copy link
Member Author

Weird, GitHub did not notify me about the reviews 👀 let me update those. Thanks, @lunatic-fox. 🙂

@Panquesito7 Panquesito7 deleted the panquesito7/update/actions branch April 28, 2023 16:22
post_screenshots_in_comment:
name: Post the screenshot
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠ This change will take effect when this commit is merged to master, as for now this action will be loading indefinitely to find a ubuntu-18.04 machine.

@Panquesito7 Panquesito7 mentioned this pull request Jul 25, 2023
1 task
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* Update many of the actions to their latest version

* Fix CodeQL action

* Use the latest version for all images

* Whoops

* Use Ubuntu for the Peek Icons workflow

* Fix Peek Icons action

* Remove token

* chore: apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

---------

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops Devops/automation related enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants