new icon: trpc (original, original-wordmark, plain, plain-wordmark) #1742

sinuheshinbr · 2023-04-24T00:14:48Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes #1732

Link to prove your SVG is correct and up-to-date.

- Add `altnames` to `trpc` entry - Remove trailing comma at `tags` - Remove `fill-rule` of icons

lunatic-fox

Hello there! 👋🏼
The icons are pretty good, but they are different from the official logos, please consider to use the listed below to base the new icons.

original

original-wordmark

Remember to choose only one original-wordmark version.

With this change plain and plain-wordmark will need to be new monocolor icons.

In devicon.json the versions property should be like:

        "versions": {
            "svg": [
                "original",
                "original-wordmark",
                "plain",
                "plain-wordmark"
            ],
            "font": [
                "plain",
                "plain-wordmark"
            ]
        },

- Unify `plain-wordmark` paths - Remove `fill` color from `plain` and `plain-wordmark`

lunatic-fox · 2023-04-25T19:48:25Z

Thank you for the fast response! 🚀

Snailedlt

Almost there. Just a few suggestions :)

devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

lunatic-fox · 2023-04-28T16:47:46Z

Sorry, I made a little mistake on icon name. Fixed!

Panquesito7 · 2023-04-28T18:10:45Z

It appears the screenshot won't be sent due that the workflow is being taken from the master branch, and the workflows are still using the Ubuntu 18.04 image, which is no longer supported in GitHub Actions.
We can manually upload these icons to Icomoon and see the results, though.

https://github.com/devicons/devicon/actions/runs/4832860711

Panquesito7

Looks good. Thanks! 🚀

P.S.: we will need to make a release ASAP.

lunatic-fox · 2023-04-28T18:16:07Z

It appears the screenshot won't be sent due that the workflow is being taken from the master branch, and the workflows are still using the Ubuntu 18.04 image, which is no longer supported in GitHub Actions. We can manually upload these icons to Icomoon and see the results, though.

https://github.com/devicons/devicon/actions/runs/4832860711

Yes, I made a note on #1731.

lunatic-fox

Great work! Everything looks fine! ✔
Thank you for this contribution! 🚀

…evicons#1742) * added trpc * Fix `devicon.json` and make a little optimization to icons. - Add `altnames` to `trpc` entry - Remove trailing comma at `tags` - Remove `fill-rule` of icons * updated original icons and added plain versions * Optimize icons - Unify `plain-wordmark` paths - Remove `fill` color from `plain` and `plain-wordmark` * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> --------- Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com>

sinuheshinbr and others added 3 commits April 23, 2023 21:08

added trpc

bb33416

Merge branch 'develop' into feature/trpc

56d364a

Fix devicon.json and make a little optimization to icons.

613ee23

- Add `altnames` to `trpc` entry - Remove trailing comma at `tags` - Remove `fill-rule` of icons

lunatic-fox requested changes Apr 25, 2023

View reviewed changes

lunatic-fox changed the title ~~new icon: tRPC (original, original-wordmark)~~ new icon: trcp (original, original-wordmark) Apr 25, 2023

sinuheshinbr and others added 2 commits April 25, 2023 15:38

updated original icons and added plain versions

53702bb

Optimize icons

abc6de2

- Unify `plain-wordmark` paths - Remove `fill` color from `plain` and `plain-wordmark`

lunatic-fox added feature:icon PR when a new icon is ready to be added to the collection bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 25, 2023

Snailedlt requested changes Apr 26, 2023

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

devicon.json Show resolved Hide resolved

Snailedlt added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger bot:check Trigger check-bot. Remove and re-add the label to re-trigger labels Apr 26, 2023

Snailedlt changed the title ~~new icon: trcp (original, original-wordmark)~~ new icon: trcp (original, original-wordmark, plain, plain-wordmark) Apr 26, 2023

sinuheshinbr and others added 3 commits April 26, 2023 15:11

Update devicon.json

6b2199b

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Update devicon.json

6ff604e

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Merge branch 'develop' into feature/trpc

d43e85a

lunatic-fox added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 26, 2023

Merge branch 'develop' into feature/trpc

2dfc2c9

Panquesito7 added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 28, 2023

lunatic-fox changed the title ~~new icon: trcp (original, original-wordmark, plain, plain-wordmark)~~ new icon: trpc (original, original-wordmark, plain, plain-wordmark) Apr 28, 2023

lunatic-fox added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 28, 2023

Panquesito7 approved these changes Apr 28, 2023

View reviewed changes

lunatic-fox approved these changes Apr 28, 2023

View reviewed changes

Panquesito7 merged commit d8f4c48 into devicons:develop Apr 28, 2023

sinuheshinbr deleted the feature/trpc branch April 28, 2023 20:19

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: trpc (original, original-wordmark, plain, plain-wordmark) #1742

new icon: trpc (original, original-wordmark, plain, plain-wordmark) #1742

Uh oh!

sinuheshinbr commented Apr 24, 2023

Uh oh!

lunatic-fox left a comment

Uh oh!

lunatic-fox commented Apr 25, 2023

Uh oh!

Snailedlt left a comment

Uh oh!

Uh oh!

Uh oh!

lunatic-fox commented Apr 28, 2023

Uh oh!

Panquesito7 commented Apr 28, 2023

Uh oh!

Panquesito7 left a comment

Uh oh!

lunatic-fox commented Apr 28, 2023 •

edited

Loading

Uh oh!

lunatic-fox left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

new icon: trpc (original, original-wordmark, plain, plain-wordmark) #1742

new icon: trpc (original, original-wordmark, plain, plain-wordmark) #1742

Uh oh!

Conversation

sinuheshinbr commented Apr 24, 2023

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

Uh oh!

lunatic-fox left a comment

Choose a reason for hiding this comment

Uh oh!

lunatic-fox commented Apr 25, 2023

Uh oh!

Snailedlt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lunatic-fox commented Apr 28, 2023

Uh oh!

Panquesito7 commented Apr 28, 2023

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

lunatic-fox commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lunatic-fox left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lunatic-fox commented Apr 28, 2023 •

edited

Loading