Skip to content

Update open methods to return nullable String#797

Merged
devnatan merged 1 commit intodevnatan:mainfrom
SmiteMCde:fix/nullable-open-string
Sep 24, 2025
Merged

Update open methods to return nullable String#797
devnatan merged 1 commit intodevnatan:mainfrom
SmiteMCde:fix/nullable-open-string

Conversation

@Leon-JavaScript
Copy link
Copy Markdown
Contributor

This PR fixes the following issue sometimes occurring on Minestom servers:

java.lang.NullPointerException: internalOpen(...) must not be null at
me.devnatan.inventoryframework.ViewFrame.open(ViewFrame.kt:85) at
me.devnatan.inventoryframework.ViewFrame.open(ViewFrame.kt:47) at
me.devnatan.inventoryframework.ViewFrame.open(ViewFrame.kt:33)

This happens because in ViewFrame.java#L160 the internalOpen method can possibly return null, but the open method in ViewFrame.kt#L85 wants to always return a String and not null.


Closes #767

@devnatan
Copy link
Copy Markdown
Owner

LGTM thx @Leon-JavaScript :))

@devnatan devnatan merged commit 5d03a59 into devnatan:main Sep 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internalOpen(...) must not be null

2 participants