Skip to content

Update open methods to return nullable String #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devnatan merged 1 commit into from
Sep 24, 2025
Merged

Update open methods to return nullable String #797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...y-framework-platform-minestom/src/main/kotlin/me/devnatan/inventoryframework/ViewFrame.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class ViewFrame private constructor(
fun open(
viewClass: Class<out View>,
player: Player,
): String = open(viewClass, player, null)
): String? = open(viewClass, player, null)

/**
* Opens a view to a player with initial data.
Expand All @@ -44,7 +44,7 @@ class ViewFrame private constructor(
viewClass: Class<out View>,
player: Player,
initialData: Any?,
): String = open(viewClass, listOf(player), initialData)
): String? = open(viewClass, listOf(player), initialData)

/**
* Opens a view to more than one player.
Expand All @@ -62,7 +62,7 @@ class ViewFrame private constructor(
fun open(
viewClass: Class<out View>,
players: Collection<Player>,
): String = open(viewClass, players, null)
): String? = open(viewClass, players, null)

/**
* Opens a view to more than one player with initial data.
Expand All @@ -82,7 +82,7 @@ class ViewFrame private constructor(
viewClass: Class<out View>,
players: Collection<Player>,
initialData: Any?,
): String = internalOpen(viewClass, players.associateBy { it.uuid.toString() }, initialData)
): String? = internalOpen(viewClass, players.associateBy { it.uuid.toString() }, initialData)

/**
* Opens an already active context to a player.
Expand Down
Loading