Skip to content

chore: update rust from 1.75 to 1.81#65

Closed
ielashi wants to merge 7 commits intomainfrom
ielashi/update_rust
Closed

chore: update rust from 1.75 to 1.81#65
ielashi wants to merge 7 commits intomainfrom
ielashi/update_rust

Conversation

@ielashi
Copy link
Copy Markdown
Collaborator

@ielashi ielashi commented Sep 12, 2024

No description provided.

@ielashi ielashi marked this pull request as ready for review September 18, 2024 11:21
@ielashi ielashi requested a review from a team as a code owner September 18, 2024 11:21
@ielashi ielashi enabled auto-merge (squash) September 18, 2024 11:21
dsarlis
dsarlis previously approved these changes Oct 25, 2024
@dsarlis
Copy link
Copy Markdown
Contributor

dsarlis commented Oct 25, 2024

@ielashi It seems that we might have an issue here. The state_check benchmark seems to be giving different results for Linux and Macos builds. I saw an error in a test for Linux and attempting to fix that broke the same on Macos. First, it's weird that we get different instructions on different platforms but, ok, let's say that's fine, what should we do? Should we have 2 versions of expected results, one per platform?

@ielashi
Copy link
Copy Markdown
Collaborator Author

ielashi commented Nov 13, 2024

@dsarlis Thanks for flagging this. Let me circle back on this at some point. Ideally, we shouldn't have different benchmarks for different platforms. This PR isn't urgent on my side or blocking anything.

@berestovskyy
Copy link
Copy Markdown
Contributor

Closing in favor of #83

auto-merge was automatically disabled March 4, 2025 12:59

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants