Skip to content

ci: Upgrade Rust toolchain to 1.84#83

Merged
berestovskyy merged 9 commits intomainfrom
andriy/upgrade-rust-1-81
Mar 4, 2025
Merged

ci: Upgrade Rust toolchain to 1.84#83
berestovskyy merged 9 commits intomainfrom
andriy/upgrade-rust-1-81

Conversation

@berestovskyy
Copy link
Copy Markdown
Contributor

@berestovskyy berestovskyy commented Mar 3, 2025

The upgrade is required by the dfinity/stable-structures#267

@berestovskyy berestovskyy changed the title Upgrade Rust toolchain to 1.81 ci: Upgrade Rust toolchain to 1.81 Mar 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2025

canbench 🏋 (dir: examples/btreemap_vs_hashmap)

Significant performance change detected! ⚠️

examples/btreemap_vs_hashmap/canbench_results.yml is up to date ✅


---------------------------------------------------

Benchmark: insert_users
  total:
    instructions: 2.55 B (-0.65%) (change within noise threshold)
    heap_increase: 871 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: remove_users
  total:
    instructions: 2.11 B (1.78%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: pre_upgrade_bench
  total:
    instructions: 807.87 M (regressed by 8.59%)
    heap_increase: 519 pages (no change)
    stable_memory_increase: 184 pages (no change)

  serialize_state (scope):
    instructions: 792.94 M (regressed by 8.76%)
    heap_increase: 519 pages (no change)
    stable_memory_increase: 0 pages (no change)

  writing_to_stable_memory (scope):
    instructions: 14.93 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 184 pages (no change)

---------------------------------------------------

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2025

canbench 🏋 (dir: examples/fibonacci)

Significant performance change detected! ⚠️

examples/fibonacci/canbench_results.yml is up to date ✅


---------------------------------------------------

Benchmark: fibonacci_20
  total:
    instructions: 2187 (-1.66%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: fibonacci_45
  total:
    instructions: 2925 (improved by 2.86%)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Comment thread .github/workflows/ci.yml
Comment thread canbench-rs/src/lib.rs
Comment thread tests/init_arg/src/main.rs
@berestovskyy berestovskyy marked this pull request as ready for review March 4, 2025 09:32
@berestovskyy berestovskyy requested a review from a team as a code owner March 4, 2025 09:32
@berestovskyy
Copy link
Copy Markdown
Contributor Author

I was not aware this PR duplicates #65

Since this PR is now passing all checks, we've decided to move forward with it.

Comment thread .github/workflows/ci.yml Outdated
@berestovskyy berestovskyy changed the title ci: Upgrade Rust toolchain to 1.81 ci: Upgrade Rust toolchain to 1.84 Mar 4, 2025
@berestovskyy berestovskyy enabled auto-merge (squash) March 4, 2025 12:29
@berestovskyy berestovskyy merged commit 6f662ee into main Mar 4, 2025
@berestovskyy berestovskyy deleted the andriy/upgrade-rust-1-81 branch March 4, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants