feature: Service-worker. Add certified streaming for chunkified assets#5
Closed
3cL1p5e7 wants to merge 1 commit intodfinity:masterfrom
Closed
feature: Service-worker. Add certified streaming for chunkified assets#53cL1p5e7 wants to merge 1 commit intodfinity:masterfrom
3cL1p5e7 wants to merge 1 commit intodfinity:masterfrom
Conversation
Contributor
|
droid update |
|
Dear @3cL1p5e7, This repository does not accept external contributions yet. We are therefore closing this Pull Request, thank you for your understanding. — The DFINITY Foundation |
|
Dear @3cL1p5e7, This repository does not accept external contributions yet. We are therefore closing this Pull Request, thank you for your understanding. — The DFINITY Foundation |
2 similar comments
|
Dear @3cL1p5e7, This repository does not accept external contributions yet. We are therefore closing this Pull Request, thank you for your understanding. — The DFINITY Foundation |
|
Dear @3cL1p5e7, This repository does not accept external contributions yet. We are therefore closing this Pull Request, thank you for your understanding. — The DFINITY Foundation |
gitlab-dfinity
pushed a commit
that referenced
this pull request
May 10, 2024
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
for assets over 2mb size, verification did not pass. This is because the worker only loads and checks the sha256-hashes of the first chunk. Obviously, the hash of the chunk and the hash of the entire file (in
sha256field) do not match.Solution:
Make service-worker to load and concat all chunks before hash-check.
Important
This PR is related, but not blocked by 2 others
dfinity/icp-js-core#527
dfinity/certified-assets#22
Comments:
Jestbecause I caught an errorWrong magic numberwhen I didIDL.encode -> IDL.decode. Current Jest setup corresponds todfinity/agent-js/agentsetup.fetch: self.fetch.bind(self)is passed toHttpAgentintentionally. See fix: fetch binding icp-js-core#527Waiting for comments on implementation