Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

feat: upgrade HTTP calls upon canister's request#6

Merged
Daniel-Bloom-dfinity merged 2 commits intodfinity:mainfrom
paulyoung:paulyoung/http-request
Jan 10, 2022
Merged

feat: upgrade HTTP calls upon canister's request#6
Daniel-Bloom-dfinity merged 2 commits intodfinity:mainfrom
paulyoung:paulyoung/http-request

Conversation

@paulyoung
Copy link
Copy Markdown
Contributor

@paulyoung paulyoung commented Dec 22, 2021 •
edited
Loading

This applies changes from dfinity/agent-rs#195 that are specific to icx-proxy.

It necessarily depends on a newer version of agent-rs ic-agent and ic-utils. This will most likely be something like 10.X.0 but temporarily uses a Git URL for now.

@paulyoung
feat: upgrade HTTP calls upon canister's request
5de6b8e 
This applies changes from dfinity/agent-rs#195 that are
specific to icx-proxy.

It necessarily depends on a newer version of agent-rs and ic-utils. This will
most likely be something like 10.X.0 but temporarily uses a Git URL for now.
@paulyoung paulyoung mentioned this pull request Dec 22, 2021
Merged
@paulyoung
Copy link
Copy Markdown
Contributor Author

paulyoung commented Dec 22, 2021

This is the upstream PR: dfinity/agent-rs#291

@paulyoung paulyoung mentioned this pull request Dec 22, 2021
Closed
paulyoung
paulyoung commented Dec 22, 2021
View reviewed changes
Comment thread Cargo.toml Outdated
@ghost ghost mentioned this pull request Dec 23, 2021
Merged
@paulyoung
Copy link
Copy Markdown
Contributor Author

paulyoung commented Jan 4, 2022

Noting that in dfinity/agent-rs#195 (comment) @jplevyak said:

When we submit this, let's create an issue to upgrade the service worker to allow upgrades on the http asset path.

I think @nomeata also had some suggestions about updating an internal spec document.

@paulyoung
Copy link
Copy Markdown
Contributor Author

paulyoung commented Jan 10, 2022

@ericswanson-dfinity I saw that you released version 0.11.0 of agent-rs and ic-utils with dfinity/agent-rs#296 but thought perhaps this PR should stick with 0.10.2 for now so that there’s a version without the breaking changes.

@ghost
Copy link
Copy Markdown

ghost commented Jan 10, 2022

@ericswanson-dfinity I saw that you released version 0.11.0 of agent-rs and ic-utils with dfinity/agent-rs#296 but thought perhaps this PR should stick with 0.10.2 for now so that there’s a version without the breaking changes.

Just wanted to mention that I am not a maintainer on this project. Merge timing will be up to @Daniel-Bloom-dfinity

@Daniel-Bloom-dfinity Daniel-Bloom-dfinity merged commit f49a9f6 into dfinity:main Jan 10, 2022
@paulyoung paulyoung deleted the paulyoung/http-request branch January 11, 2022 02:22
@paulyoung
Copy link
Copy Markdown
Contributor Author

paulyoung commented Feb 9, 2022

For my own reference in future, updating the service worker looks something like this: dfinity/ic#5

@paulyoung
Copy link
Copy Markdown
Contributor Author

paulyoung commented Feb 9, 2022

…and changes to HttpRequest/HttpResponse should be tested: https://github.com/dfinity/agent-rs/pull/305/files

@dansteren dansteren mentioned this pull request Dec 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulyoung @Daniel-Bloom-dfinity