test(ckETH_Minter): DEFI-2559: Add test to verify minter cannot be stopped while it is scraping blocks#7962
Merged
mbjorkqvist merged 8 commits intomasterfrom Dec 18, 2025
Conversation
mbjorkqvist
changed the title
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks @mbjorkqvist for digging into this!
gregorydemay
approved these changes
Dec 18, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks @mbjorkqvist for that PR!
mraszyk
pushed a commit
that referenced
this pull request
Jan 5, 2026
…opped while it is scraping blocks (#7962) Add a `StateMachine` test to verify that the ckETH minter cannot be stopped while it is scraping blocks - in particular, while it is retrieving blocks in a loop, it will continue making HTTPS outcalls to retrieve new blocks until it reaches the tip, even if a controller has attempted to stop the canister in the meantime. --------- Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
Follow-up on #7962 to ensure that the minter stops scraping the logs when it is in the stopping state. This is simply done by upgrading `ic-canister-runtime` to `0.2.0` which now offers that behavior by default. --------- Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
StateMachinetest to verify that the ckETH minter cannot be stopped while it is scraping blocks - in particular, while it is retrieving blocks in a loop, it will continue making HTTPS outcalls to retrieve new blocks until it reaches the tip, even if a controller has attempted to stop the canister in the meantime.