feat(cketh/ckERC20): stop scraping when minter is stopping #8785
Merged
gregorydemay merged 21 commits intomasterfrom Mar 3, 2026
Merged
feat(cketh/ckERC20): stop scraping when minter is stopping #8785gregorydemay merged 21 commits intomasterfrom
gregorydemay merged 21 commits intomasterfrom
Conversation
gregorydemay
force-pushed
the
gdemay/DEFI-2566-prevent-calls-when-stopping
branch
from
4d36880 to
5a8e292
Compare
gregorydemay
changed the base branch from
master
to
gdemay/DEFI-2566-cketh-try-send
gregorydemay
added a commit
to dfinity/canhttp
that referenced
this pull request
Feb 17, 2026
Follow-up on #76 to ensure that by default the `IcRuntime` used in production does not make inter-canister calls when the canister is in the `Stopping` state to ensure that it can be stopped promptly. While adding this feature to this crate is easy, deploying it to ensure its correctness takes a few PRs: 1. Use new version of the `ic-canister-runtime` library in the EVM RPC client, see dfinity/evm-rpc-canister#555 2. Fix the ckETH/ckERC20 minter to avoid panicking in case of client error, see dfinity/ic#8821 3. Use new version of the EVM RPC client in the ckETH/ckERC20 minter, see dfinity/ic#8785
# Conflicts: # Cargo.Bazel.json.lock # rs/ethereum/cketh/minter/tests/cketh.rs
basvandijk
approved these changes
Feb 19, 2026
mbjorkqvist
approved these changes
Feb 20, 2026
# Conflicts: # Cargo.Bazel.json.lock # Cargo.Bazel.toml.lock # Cargo.lock
# Conflicts: # Cargo.Bazel.json.lock # Cargo.lock # Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #7962 to ensure that the minter stops scraping the logs when it is in the stopping state.
This is simply done by upgrading
ic-canister-runtimeto0.2.0which now offers that behavior by default.