Explicit casts to avoid conversion warnings [blocks: #2310] by tautschnig · Pull Request #2551 · diffblue/cbmc

tautschnig · 2018-07-07T09:34:52Z

Visual Studio warns about signed/unsigned conversion and limited range of types.

smowton · 2018-07-07T09:46:10Z

These really can't be silenced with an explicit typecast?

smowton · 2018-07-07T09:48:00Z

Also a lot of these don't appear to be related to standard library calls?

allredj

Passed Diffblue compatibility checks (cbmc commit: 5d40b60).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/78358680

tautschnig · 2018-12-28T19:31:54Z

This is now re-implemented using explicit type casts.

allredj

✔️
Passed Diffblue compatibility checks (cbmc commit: db43e7a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95906397

allredj

✔️
Passed Diffblue compatibility checks (cbmc commit: c332386).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102222178

allredj

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: d96a361).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/104504752
Status will be re-evaluated on next push.
Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).
the compatibility was already broken by an earlier merge.

allredj

✔️
Passed Diffblue compatibility checks (cbmc commit: 13856db).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/106408234

thk123

A couple of changes I think you should double check, but otherwise lgtm

thk123 · 2019-04-30T14:55:31Z

src/ansi-c/literals/unescape_string.cpp

  for(unsigned i=0; i<src.size(); i++)
  {
-    T ch=(unsigned char)src[i];
+    T ch = narrow_cast<T>(narrow_cast<unsigned char>(src[i]));


❓ Why narrow to unsigned char first? 🐭

This is to preserve the existing behaviour, as T might actually be wider than unsigned char. That said, I guess narrow_cast would fail in a case where that makes a difference, so I can probably get rid of it.

Nested cast removed.

thk123 · 2019-04-30T14:55:47Z

src/ansi-c/literals/unescape_string.cpp

      assert(i<src.size()); // backslash can't be last character

-      ch=(unsigned char)src[i];
+      ch = narrow_cast<T>(narrow_cast<unsigned char>(src[i]));


thk123 · 2019-04-30T14:57:06Z

src/goto-programs/read_goto_binary.cpp

        if(elf_reader.section_name(i)=="goto-cc")
        {
-          in.seekg(elf_reader.section_offset(i));
+          in.seekg(std::streamoff{elf_reader.section_offset(i)});


❓ Is this change meant to be here?

Yes, because section_offset returns a std::streampos (which makes sense in other contexts).

allredj

✔️
Passed Diffblue compatibility checks (cbmc commit: 36b9d0c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113768512

Visual Studio warns about signed/unsigned conversion and limited range of types.

…d long long Visual Studio warns about signed/unsigned conversion and limited range of types.

This avoids conversion warnings with Visual Studio.

If the inner cast actually had any effect then that would amount to a loss of precision, which in turn would necessarily fail with narrrow_cast.

allredj

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: bf8ae77).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113953221
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

TGWDB · 2023-05-03T15:21:59Z

Closing due to age (no further comment on PR content), please reopen with rebase on develop if you intent to continue this work.

tautschnig requested review from NathanJPhillips, cesaro, chrisr-diffblue, cristina-david, kroening, martin-cs, mgudemann, peterschrammel, pkesseli, romainbrenguier, smowton and thk123 as code owners July 7, 2018 09:34

allredj reviewed Jul 7, 2018

View reviewed changes

tautschnig self-assigned this Sep 4, 2018

tautschnig changed the title ~~Pragma to silence Visual Studio conversion warnings~~ Pragma to silence Visual Studio conversion warnings [blocks: #2310] Nov 7, 2018

tautschnig added the blocker label Nov 7, 2018

tautschnig force-pushed the vs-pragma-conversion branch 3 times, most recently from 2acc9aa to bace090 Compare November 15, 2018 09:08

tautschnig force-pushed the vs-pragma-conversion branch from bace090 to db43e7a Compare December 28, 2018 19:30

tautschnig changed the title ~~Pragma to silence Visual Studio conversion warnings [blocks: #2310]~~ Explicit casts to avoid conversion warnings [blocks: #2310] Dec 28, 2018

tautschnig removed their assignment Dec 28, 2018

allredj reviewed Dec 28, 2018

View reviewed changes

tautschnig force-pushed the vs-pragma-conversion branch 2 times, most recently from b72b9d0 to 7c61bdb Compare January 4, 2019 16:29

tautschnig mentioned this pull request Jan 16, 2019

Define big-int operators for signed long [blocks: #2551] #3812

Merged

4 tasks

tautschnig mentioned this pull request Jan 23, 2019

Fix narrowing conversions seen by test-gen #3900

Merged

4 tasks

allredj reviewed Feb 25, 2019

View reviewed changes

tautschnig self-assigned this Mar 8, 2019

tautschnig force-pushed the vs-pragma-conversion branch from c332386 to d96a361 Compare March 14, 2019 20:49

allredj reviewed Mar 15, 2019

View reviewed changes

tautschnig force-pushed the vs-pragma-conversion branch from d96a361 to 13856db Compare March 30, 2019 00:27

tautschnig removed their assignment Mar 30, 2019

allredj reviewed Mar 30, 2019

View reviewed changes

kroening approved these changes Apr 30, 2019

View reviewed changes

kroening assigned thk123 and unassigned kroening Apr 30, 2019

thk123 reviewed Apr 30, 2019

View reviewed changes

tautschnig force-pushed the vs-pragma-conversion branch 4 times, most recently from 02abb9a to 36b9d0c Compare May 30, 2019 14:01

allredj reviewed May 30, 2019

View reviewed changes

romainbrenguier approved these changes May 31, 2019

View reviewed changes

tautschnig added 8 commits May 31, 2019 21:46

Explicit casts to avoid conversion warnings: std::size_t

3a6ad06

Visual Studio warns about signed/unsigned conversion and limited range of types.

Explicitly cast bytes read from binaries to signed values

03de057

Visual Studio warns about signed/unsigned conversion and limited range of types.

Explicitly cast returnvalue of tolower to char

60e7824

Visual Studio warns about signed/unsigned conversion and limited range of types.

std::distance returns a signed type, wrap in explicit cast

93f4576

Visual Studio warns about signed/unsigned conversion and limited range of types.

Explicit casts to avoid conversion warnings

5cad6e1

Visual Studio warns about signed/unsigned conversion and limited range of types.

Explicit casts to avoid conversion warnings: irept::set takes a signe…

fbebbac

…d long long Visual Studio warns about signed/unsigned conversion and limited range of types.

Use auto where type does not matter (and is likely signed)

0cad50e

This avoids conversion warnings with Visual Studio.

Remove nested cast

bf8ae77

If the inner cast actually had any effect then that would amount to a loss of precision, which in turn would necessarily fail with narrrow_cast.

tautschnig force-pushed the vs-pragma-conversion branch from 36b9d0c to bf8ae77 Compare May 31, 2019 21:47

allredj reviewed May 31, 2019

View reviewed changes

tautschnig self-assigned this Nov 20, 2022

TGWDB closed this May 3, 2023

Conversation

tautschnig commented Jul 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smowton commented Jul 7, 2018

Uh oh!

smowton commented Jul 7, 2018

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

tautschnig commented Dec 28, 2018

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

thk123 left a comment

Choose a reason for hiding this comment

Uh oh!

thk123 Apr 30, 2019

Choose a reason for hiding this comment

Uh oh!

tautschnig May 1, 2019

Choose a reason for hiding this comment

Uh oh!

tautschnig May 30, 2019

Choose a reason for hiding this comment

Uh oh!

thk123 Apr 30, 2019

Choose a reason for hiding this comment

Uh oh!

tautschnig May 30, 2019

Choose a reason for hiding this comment

Uh oh!

thk123 Apr 30, 2019

Choose a reason for hiding this comment

Uh oh!

tautschnig May 1, 2019

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

TGWDB commented May 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

tautschnig commented Jul 7, 2018 •

edited

Loading