Define big-int operators for signed long [blocks: #2551]#3812
Define big-int operators for signed long [blocks: #2551]#3812kroening merged 1 commit intodiffblue:developfrom
Conversation
martin-cs
left a comment
There was a problem hiding this comment.
Seems reasonable, esp. to match unsigned long although it's not entirely clear to me why this is needed now.
02999d3 to
b341b65
Compare
Trying to use numeric_cast_v<signed long> resulted in ambiguous overload errors. At the moment, we are in a few places wrongly using `numeric_cast_v<std::size_t>` when it should be `numeric_cast_v<std::ptrdiff_t>`. On non-Windows platforms, `std::ptrdiff_t` is `signed long`. To enable the use of the correct `numeric_cast_v`, we need to support the comparison operators.
b341b65 to
427cc92
Compare
|
The need for this arises with #2310/#2551 which cleans up all signed/unsigned conversions that Visual Studio is unhappy about. At the moment, we are in a few places wrongly using |
allredj
left a comment
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: b341b65).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97523246
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 427cc92).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97524640
|
@tautschnig : thanks! |
Trying to use numeric_cast_v resulted in ambiguous overload errors.