Generalise get_subexpression_at_offset to extract parts of members#3167
Conversation
tautschnig
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
pkesseli and
smowton
as code owners
| // try to build a member/index expression - do not use byte_extract | ||
| exprt subexpr = get_subexpression_at_offset( | ||
| root_object_subexpression, o.offset(), dereference_type, ns); | ||
| root_object_subexpression, o.offset(), dereference_type, "", ns); |
There was a problem hiding this comment.
Having an empty string literal, interpreted as an irep ID, to block particular functionality (descending within objects if I understand correctly) does not seem like the most intuitive of designs. I can't immediately suggest better though.
tautschnig
force-pushed
the
get_subexpr-parts-of-members
branch
from
0ab3688 to
827094b
Compare
tautschnig
requested review from
NathanJPhillips,
cesaro,
cristina-david and
thk123
as code owners
|
Marking do-not-merge as this depends on #3184. |
tautschnig
force-pushed
the
get_subexpr-parts-of-members
branch
2 times, most recently
from
8d7fbad to
dc227a0
Compare
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 8d7fbad).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89566003
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
tautschnig
force-pushed
the
get_subexpr-parts-of-members
branch
from
dc227a0 to
aa683aa
Compare
|
Dependencies have been merged, this is now ready for review. |
tautschnig
assigned
smowton,
kroening,
peterschrammel,
martin-cs,
pkesseli and
chrisr-diffblue and unassigned
tautschnig
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: aa683aa).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89578879
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
Recommend name your variables after units given bytes and bits are both used in the same function; otherwise looks good
This enables re-use in the simplifier and other places. Adding a unit test of get_subexpression_at_offset.
tautschnig
force-pushed
the
get_subexpr-parts-of-members
branch
from
aa683aa to
2ff4d2f
Compare
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 2ff4d2f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89808073
8 participants
This enables re-use in the simplifier and other places. Adding a unit test of
get_subexpression_at_offset.