C++ bool is at least one byte wide#3184
Merged
tautschnig merged 1 commit intodiffblue:developfrom Oct 29, 2018
Merged
Conversation
Collaborator
|
I'm listed as a reviewer for this but the specific commit that is novel to this branch doesn't seem to touch "my" areas. Am happy to review but I'd suggest we get the supporting things merged first. |
Collaborator
Author
|
Adding do-not-merge (to be read as "do not review"). |
4 tasks
2c1a22d to
33d41e5
Compare
Do not treat "bool" as a single bit, which is what __CPROVER_bool is for.
kroening
approved these changes
Oct 29, 2018
allredj
reviewed
Oct 29, 2018
Contributor
allredj
left a comment
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: fd39953).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89554493
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not treat "bool" as a single bit, which is what __CPROVER_bool is for.