Conversation
mgudemann
force-pushed
the
limit_class_loading
branch
from
64b5643 to
346d57e
Compare
|
What's the advantage of that in comparison to lazy class loading (#407)? |
|
It's in addition to lazy loading. If I understand correctly, lazy loading will only load the parts that are actually used and not everything that is present. This allows you to limit beforehand what is seen from a jar file, @marek-trtik had asked for such a feature. |
|
I see. These two are orthogonal. |
|
cegis needs json.a to compile: https://travis-ci.org/diffblue/cbmc/jobs/208614294#L2370 |
mgudemann
force-pushed
the
limit_class_loading
branch
from
fb4917f to
8e96c2a
Compare
|
added json.a to cegis Makefile |
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
Various requests for cleanup and logic simplifications.
src/java_bytecode/jar_file.cpp
Outdated
There was a problem hiding this comment.
Nit picking: group STL headers, only then start with local headers
src/java_bytecode/jar_file.cpp
Outdated
There was a problem hiding this comment.
Is iostream really required?
src/java_bytecode/jar_file.cpp
Outdated
There was a problem hiding this comment.
This is not an internal error (it's invalid user input), I think - should be throw instead of assert.
src/java_bytecode/jar_file.cpp
Outdated
There was a problem hiding this comment.
As above: invalid user input, not an internal error.
src/java_bytecode/jar_file.cpp
Outdated
There was a problem hiding this comment.
Why use count() instead of find?
There was a problem hiding this comment.
because it was shorter, also it is an unordered map so it shouldn't be less efficient as count can only be 0 or 1 and if an element is found, the implemention likely stops traversing the unordered map. In any case, I change this to find() to be consistent with the code base.
src/java_bytecode/jar_file.h
Outdated
There was a problem hiding this comment.
This is a user input, I believe?! Should be thrown, not asserted.
src/java_bytecode/jar_file.h
Outdated
There was a problem hiding this comment.
Does jar_filet benefit from being a messaget (see comments above)?
There was a problem hiding this comment.
I'll add a status output to see about hidden files, also the JSON parser needs a valid one
There was a problem hiding this comment.
Please add a blank line. Codewithoutblanksisreallyhardtoread.
There was a problem hiding this comment.
See above for why I believe these aren't internal errors.
e.g.
```
{
"jar":
[
"A.jar",
"B.jar"
],
"classFiles":
[
"jarfile3$A.class",
"jarfile3.class"
]
}
```
mgudemann
force-pushed
the
limit_class_loading
branch
from
8e96c2a to
1975394
Compare
mgudemann
force-pushed
the
limit_class_loading
branch
from
eae1b8b to
53fad70
Compare
…p_on_exception [SEC-677] Turning DI off by default and making errors fail pipeline
4 participants
This PR adds the capability to load only the subset of class files from a jar which match a regex specified via the
java-cp-include-filesparameter.requires #548