Conversation
mgudemann
force-pushed
the
war_load_support
branch
3 times, most recently
from
a8b2c79 to
015a52f
Compare
There was a problem hiding this comment.
I very much appreciate that comment - but you might even place it in the test.desc file (so as not to create a non-standard file): you can place comments after another --, see test.pl --help
src/java_bytecode/jar_file.cpp
Outdated
There was a problem hiding this comment.
Would that also be the prefix on Windows?
src/java_bytecode/jar_file.cpp
Outdated
There was a problem hiding this comment.
Would that also be the prefix on Windows?
There was a problem hiding this comment.
apparently, yes, cf. https://en.wikipedia.org/wiki/WAR_(file_format)
what's currently missing though, is loading of jars listed in WEB-INF/lib
There was a problem hiding this comment.
(Maybe worth adding that link as a comment in the source code.)
mgudemann
force-pushed
the
war_load_support
branch
2 times, most recently
from
d3b91ff to
4ae4273
Compare
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
A nit pick about blank lines, but mainly my please-change-this request is about the url.txt file that I'd prefer to see go away. See comment.
src/java_bytecode/jar_file.cpp
Outdated
There was a problem hiding this comment.
I'd rather have more blank lines that fewer - is there a reason (such as IDEs doing automatic work) why this line is gone?
There was a problem hiding this comment.
re-added this line and one in front of documentation block for the function afterwards
no particular reason for having removed it
|
please note that this PR is not yet complete, as loading of jars in the war is not yet supported |
|
Should it be tagged do-not-merge? |
|
currently, yes, but I cannot do the tagging apparently |
mgudemann
force-pushed
the
war_load_support
branch
from
2180ce1 to
4f42f7f
Compare
|
I brought this up to current |
|
I am going to close this PR as it appears that work on it has been inactive for an extended period of time. This is not any judgement on how worthwhile this work is. This is part of an effort to reduce the number of open PRs which are not being actively worked on. If you still think it would be worthwhile to get this merged then the branch should be re-based on the latest version of develop and the PR re-opened. |
3 participants
This adds support to load class files from web application archive (WAR) files.
requires #604