Add validations for frame number and instances being None#19
Merged
anthony-chaudhary merged 1 commit intomainfrom Nov 30, 2021
Merged
Add validations for frame number and instances being None#19anthony-chaudhary merged 1 commit intomainfrom
anthony-chaudhary merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK was allowing to send the backend and instance_list with the shape
[None, None, NoneThis PR fixes that.
Also added
frame_numberkey as a required key when we are sending a frame packet map.I believe
frame_numbershould be a required key always, but if there's a case where it would not be that way please let me know so we can discuss this further.