Skip to content

Add validations for frame number and instances being None #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-chaudhary merged 1 commit into from
Nov 30, 2021
Merged

Add validations for frame number and instances being None #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions sdk/diffgram/file/file_constructor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,8 @@ def __validate_and_format_frame_packet_map(
raise Exception("frame_packet_map is not a dict")

for frame, instance_list in frame_packet_map.items():
if instance_list is None:
raise Exception("instance_list cannot be None")

if type(frame) != int:
raise Exception("frame is not a integer. The key should be the integer frame number.")
Expand All @@ -312,7 +314,8 @@ def __validate_and_format_frame_packet_map(
frame_packet_map[frame] = self.__validate_and_format_instance_list(
instance_list = instance_list,
assume_new_instances_machine_made = assume_new_instances_machine_made,
convert_names_to_label_files = convert_names_to_label_files
convert_names_to_label_files = convert_names_to_label_files,
check_frame_number = True
)

return frame_packet_map
Expand All @@ -321,7 +324,8 @@ def __validate_and_format_instance_list(
self,
instance_list: list,
assume_new_instances_machine_made: bool,
convert_names_to_label_files: bool):
convert_names_to_label_files: bool,
check_frame_number: bool = False ):

FileConstructor.sanity_check_instance_list(instance_list)

Expand All @@ -334,6 +338,11 @@ def __validate_and_format_instance_list(
instance_list = instance_list
)

if check_frame_number:
for elm in instance_list:
if elm.get('frame_number') is None:
raise Exception('All instances must have a "frame_number" key.')

return instance_list

def instance_list_label_strings_to_ids(self, instance_list: list):
Expand Down Expand Up @@ -368,6 +377,10 @@ def sanity_check_instance_list(instance_list: list):
if len(instance_list) == 0:
raise Warning("'instance_list' is empty")

for elm in instance_list:
if elm is None:
raise Exception("instance_list elements cannot be None")

FileConstructor.__check_for_duplicates_on_instance_list(instance_list)

return
Expand Down