Closed
Conversation
Contributor
Author
|
@leshy A bit of a mega shit PR. But best way to integrate contact graspnet |
Contributor
|
move the model.pt to lfs |
leshy
previously approved these changes
Jun 27, 2025
Contributor
leshy
left a comment
leshy
left a comment
There was a problem hiding this comment.
idk what this is, I assume temporary, hope we somehow extract this, so not reviewing the code.
hard to review the interface, I need deeper understanding of architecture of manipulation stuff, rope me into it when you feel I'm useful to review, aproving for now
Contributor
Author
|
This was replaced by #370 which included amending our contact graspnet fork to allow for install as a python package, which it was not built for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.