Run mypy checks in CI

[paul-nechifor]

No description provided.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[greptile-apps]

Greptile Overview

Greptile Summary

Added mypy type checking to CI pipeline that runs in parallel with other tests using the ros-dev container with ROS Humble type stubs.

• Integrated mypy job into existing test workflow with same dependency pattern as ros tests
• Configured MYPYPATH to include ROS Humble Python packages for proper type resolution
• Uses ros-dev image to ensure ROS types are available during type checking

Confidence Score: 3/5

• This PR has a configuration mismatch that may cause inconsistent type checking results
• The workflow implementation follows existing patterns correctly and mypy is properly configured with ROS types, but there's a Python version mismatch between the mypy config (3.12) and runtime environment (3.10) that needs addressing
• Review .github/workflows/docker.yml:221 for Python version configuration

Important Files Changed

File Analysis

Filename	Score	Overview
.github/workflows/docker.yml	3/5	Added mypy type checking job with ROS types support, but Python version mismatch between config (3.12) and runtime (3.10)

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant CC as check-changes
    participant ROS as ros-dev build
    participant Tests as run-ros-tests
    participant MyPy as run-mypy

    GH->>CC: Trigger on push/PR
    CC->>CC: Filter changed paths
    CC->>CC: Determine branch tag
    
    CC->>ROS: Build ros-dev image (if needed)
    
    ROS->>Tests: Image ready/skipped
    ROS->>MyPy: Image ready/skipped
    
    par Parallel execution
        Tests->>Tests: Run pytest with ROS tests
        MyPy->>MyPy: Set MYPYPATH to ROS packages
        MyPy->>MyPy: Execute mypy type checking on dimos/
    end
    
    Tests-->>GH: Test results
    MyPy-->>GH: Type check results

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[paul-nechifor]

Closed. Replaced with #805 .