Run mypy checks in GitHub Actions

[paul-nechifor]

• This PR uses Python 3.10 and ROS Humble to run the mypy checks.
• The previous PR, Run mypy checks in CI #790, now closed, used Python 3.12 and ROS Jazzy.
• Added a convenience script to run mypy through docker so that you get the same output as GitHub:

  ./bin/mypy-ros

• NOTE: the above script builds the docker images. It takes a long while the first time you run it.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR adds mypy type checking to the CI pipeline and fixes type annotations across the codebase to pass mypy 1.19.0 in strict mode.

• Added a new run-mypy CI job in .github/workflows/docker.yml that runs mypy against the dimos package with ROS package paths configured
• Updated mypy from 1.18.2 to 1.19.0 and added warn_unused_ignores = false to allow broader type ignore comments
• Added import-untyped type ignores for scipy imports across multiple files (scipy lacks type stubs)
• Added attr-defined type ignores for ultralytics imports (dynamic attribute access)
• Fixed actual type bugs in test_coordinator.py: added None checks for optional delay and frequency parameters before arithmetic operations
• Added explicit type annotation for self.storages in ZED camera module
• Added sim optional dependency to docker/python/Dockerfile pip install

Confidence Score: 5/5

• This PR is safe to merge - it consists primarily of type annotation fixes and CI configuration changes with no functional logic changes.
• All changes are type annotation additions/fixes to satisfy mypy, with minor bug fixes for None checks. The only functional changes are adding null guards that improve code safety. CI changes follow existing patterns.
• No files require special attention - all changes are straightforward type annotation fixes.

Important Files Changed

File Analysis

Filename	Score	Overview
.github/workflows/docker.yml	5/5	Added new run-mypy CI job that runs mypy on the dimos codebase with MYPYPATH set for ROS packages.
dimos/protocol/skill/test_coordinator.py	5/5	Fixed type issues: added None checks for delay/frequency parameters, fixed return type annotations and added type ignores for skill decorator.
docker/python/Dockerfile	5/5	Added sim optional dependency to the pip install command alongside cpu.
pyproject.toml	5/5	Updated mypy to 1.19.0, added warn_unused_ignores = false to mypy config to support broader type ignore comments.

Sequence Diagram

sequenceDiagram
    participant PR as Pull Request
    participant CI as GitHub Actions
    participant Docker as Docker Build
    participant Mypy as Mypy Check
    
    PR->>CI: Trigger docker.yml workflow
    CI->>Docker: Build ros-dev image
    Docker-->>CI: Image ready
    CI->>Mypy: run-mypy job
    Note over Mypy: MYPYPATH=/opt/ros/humble/lib/python3.10/site-packages
    Mypy->>Mypy: mypy dimos (strict mode)
    Mypy-->>CI: Type check results
    CI-->>PR: Pass/Fail status

Loading

[greptile-apps]

_{21 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[leshy]

amazing tnx