show get_data progress

[paul-nechifor]

No description provided.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[greptile-apps]

Greptile Summary

enabled progress visibility for git LFS downloads during MuJoCo simulation initialization

• removed capture_output=True from subprocess.run in _lfs_pull() to allow progress output to display in terminal
• added GIT_LFS_FORCE_PROGRESS=1 environment variable to force progress display even in non-TTY environments
• added eager import of mujoco_playground package in MujocoConnection.__init__() to trigger menagerie downloads in main process, preventing subprocess timeouts
• added explanatory comments for both changes

Confidence Score: 4/5

• This PR is safe to merge with minimal risk
• The changes are focused and well-intentioned (improving UX by showing progress), but the unused import in mujoco_connection.py will trigger linter warnings. The removal of capture_output is correct for displaying progress, and the environment variable approach is appropriate.
• No files require special attention beyond addressing the linter warning for the unused import

Important Files Changed

Filename	Overview
dimos/utils/data.py	enabled progress display for git lfs downloads by setting GIT_LFS_FORCE_PROGRESS and removing output capture
dimos/robot/unitree_webrtc/mujoco_connection.py	added pre-download of mujoco_sim data and eager import of mujoco_playground to prevent subprocess timeouts

Sequence Diagram

sequenceDiagram
    participant User
    participant MujocoConnection
    participant get_data
    participant git_lfs
    participant mujoco_playground
    
    User->>MujocoConnection: __init__(global_config)
    MujocoConnection->>MujocoConnection: check mujoco installed
    MujocoConnection->>get_data: get_data("mujoco_sim")
    get_data->>get_data: check if already exists
    alt file not exists
        get_data->>git_lfs: pull file with GIT_LFS_FORCE_PROGRESS=1
        Note over git_lfs: progress displayed to terminal
        git_lfs-->>get_data: file downloaded
        get_data->>get_data: decompress archive
    end
    get_data-->>MujocoConnection: return path
    MujocoConnection->>mujoco_playground: import mujoco_playground
    Note over mujoco_playground: triggers menagerie download in main process
    mujoco_playground-->>MujocoConnection: import complete
    MujocoConnection-->>User: connection initialized

Loading

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: unused import triggers linter warnings

Suggested change

	import mujoco_playground
	import mujoco_playground # noqa: F401

[leshy]

awesome