Restore MacOS Support (flake.nix)

[jeff-hykin]

No description provided.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[greptile-apps]

Greptile Summary

This PR adds comprehensive MacOS support to the Nix flake configuration, refactoring from a simple package list to a sophisticated aggregation system with platform-specific dependencies. The changes include:

• Added MacOS-specific packages (cctools, xcbuild, etc.) with conditional loading
• Implemented LCM patch for Darwin to fix fsync/fdatasync compatibility
• Created custom cc-no-usr-include wrapper to prevent pip packages from using system headers
• Added two shell environments: default (blends with host) and isolated (via xome with fake home)
• Introduced dimos_setup() helper function to automate the README installation steps
• Added instructions for enabling Nix flakes in README.md

Critical Issues:

• dimos_setup() creates venv/ but shellHook at line 217 checks for env/bin/activate - this breaks the activation flow for new setups
• Line 31 has nested flags syntax error that may cause the flake to fail evaluation
• Line 191 uses zsh-specific setopt in a bash context which will fail on systems without zsh

Other Concerns:

• The venv path inconsistency means users following the automated setup will have their virtualenv ignored by the shell

Confidence Score: 3/5

• Contains critical bugs that will break setup for new users and potentially cause flake evaluation failures
• The PR adds valuable MacOS support but has 2-3 critical bugs: the venv/env path mismatch will break new user setups, nested flags syntax error may prevent flake evaluation, and bash/zsh compatibility issue. These are straightforward to fix but will cause immediate failures.
• flake.nix requires immediate attention - lines 31, 191, and 217 have bugs that will cause failures

Important Files Changed

Filename	Overview
README.md	Added flake enablement instructions and TODO for ulimit check on MacOS - straightforward documentation updates
flake.lock	Added new dependencies (lib, xome, home-manager) for enhanced MacOS support - standard lock file updates
flake.nix	Major refactor adding MacOS support with platform-specific packages and two shell environments; includes venv/env inconsistency that breaks existing setups

Sequence Diagram

sequenceDiagram
    participant User
    participant NixDevelop as nix develop
    participant FlakeNix as flake.nix
    participant ShellHook as shellHook
    participant DimoSetup as dimos_setup()
    participant Venv as Python venv
    
    User->>NixDevelop: nix develop
    NixDevelop->>FlakeNix: Load flake configuration
    FlakeNix->>FlakeNix: Detect OS (Linux/Darwin)
    FlakeNix->>FlakeNix: Aggregate packages with flags
    FlakeNix->>FlakeNix: Apply platform-specific packages
    FlakeNix->>ShellHook: Execute shellHook
    
    alt Linux
        ShellHook->>ShellHook: Set CC=cc-no-usr-include
        ShellHook->>ShellHook: Link NVIDIA libraries
    end
    
    ShellHook->>ShellHook: Set LD_LIBRARY_PATH, PKG_CONFIG_PATH
    ShellHook->>ShellHook: Define dimos_setup() function
    
    alt venv exists
        ShellHook->>Venv: Check python path matches nix
        alt Mismatch detected
            ShellHook->>User: Warn about venv/nix mismatch
        end
        ShellHook->>Venv: Activate venv
    else No venv
        ShellHook->>User: Suggest running dimos_setup
    end
    
    opt User runs setup
        User->>DimoSetup: dimos_setup
        DimoSetup->>DimoSetup: Install git lfs
        DimoSetup->>DimoSetup: Download models (17GB)
        DimoSetup->>DimoSetup: Create .env from default.env
        DimoSetup->>Venv: Create venv (WRONG PATH)
        Note over DimoSetup,Venv: Bug: Creates venv/ but<br/>shellHook looks for env/
        DimoSetup->>Venv: pip install dependencies
        DimoSetup->>Venv: Handle platform-specific deps
        DimoSetup->>User: Run tests (optional)
    end

Loading

[greptile-apps]

_{2 files reviewed, 5 comments}

_{Edit Code Review Agent Settings | Greptile}

[jeff-hykin]

@leshy requested changes made (also moved setup_dimos into bin/_init_dev as a half-step towards unifying the logic).

Re-tested on MacOS and Linux (not full cache wipe, but venv wipe)