mac compatible commit filter

[paul-nechifor]

No description provided.

[greptile-apps]

Greptile Summary

Replaced platform-specific sed -i command with a cross-platform Python script to filter "Generated with" signatures from commit messages. The change addresses macOS compatibility issues where BSD sed requires an explicit backup extension argument for the -i flag, unlike GNU sed on Linux.

Key changes:

• Replaced sed -i '/^.*Generated with/,$d' with python bin/hooks/filter_commit_message.py in .pre-commit-config.yaml:99
• Added new Python script that reads commit message file, filters out lines from "Generated with" onwards, and writes back the result
• Changed language from system to python for the pre-commit hook

Review notes:

• The script properly handles edge cases (missing file, no arguments)
• The filtering logic is functionally equivalent to the original sed command
• One minor consideration: trailing newline behavior differs slightly but shouldn't cause issues in practice

Confidence Score: 5/5

• Safe to merge - well-implemented macOS compatibility fix with proper error handling
• The change is a straightforward platform compatibility fix that replaces a problematic sed -i command with equivalent Python code. The implementation includes proper argument validation, file existence checks, and clear logic. The only minor consideration is trailing newline handling, which is a style preference and won't cause functional issues.
• No files require special attention

Important Files Changed

Filename	Overview
.pre-commit-config.yaml	Replaced sed -i with Python script for macOS compatibility
bin/hooks/filter_commit_message.py	New Python script to filter commit message signatures, handles edge cases but has one potential issue with trailing newlines

Sequence Diagram

sequenceDiagram
    participant Git as Git Commit
    participant PreCommit as Pre-commit Hook
    participant Script as filter_commit_message.py
    participant File as Commit Message File

    Git->>PreCommit: commit-msg stage triggered
    PreCommit->>Script: Execute with commit msg file path
    
    alt File doesn't exist
        Script->>PreCommit: Exit with code 0
    else File exists
        Script->>File: Read commit message
        File-->>Script: Return lines with newlines
        
        Script->>Script: Iterate through lines
        
        alt Line contains "Generated with"
            Script->>Script: Break loop (discard remaining lines)
        else Line doesn't contain "Generated with"
            Script->>Script: Append to filtered_lines
        end
        
        Script->>File: Write filtered lines back
        Script->>PreCommit: Exit with code 0
    end
    
    PreCommit->>Git: Continue commit process

Loading

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: Trailing newline may be removed when commit message ends exactly at "Generated with" line. If filtered_lines is empty or the last line doesn't end with a newline, the output may differ from original sed behavior.

Suggested change

	lines = commit_msg_file.read_text().splitlines(keepends=True)
	# Find the first line containing "Generated with" and truncate there
	filtered_lines = []
	for line in lines:
	if "Generated with" in line:
	break
	filtered_lines.append(line)
	commit_msg_file.write_text("".join(filtered_lines))
	lines = commit_msg_file.read_text().splitlines(keepends=True)
	# Find the first line containing "Generated with" and truncate there
	filtered_lines = []
	for line in lines:
	if "Generated with" in line:
	break
	filtered_lines.append(line)
	# Ensure we maintain at least one newline at the end if original had content
	result = "".join(filtered_lines)
	if result and not result.endswith('\n') and lines:
	result += '\n'
	commit_msg_file.write_text(result)