Closed
Conversation
Contributor
Greptile SummaryRemoved the Pikchr diagram source code from the ReactiveX documentation while keeping the reference to the generated SVG file. The collapsible Key changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Docs as Documentation File
participant Pikchr as Pikchr Source
participant SVG as Generated SVG
participant Reader as Documentation Reader
Dev->>Docs: Identify collapsible Pikchr source
Note over Docs,Pikchr: Source wrapped in details/summary tags
Dev->>Pikchr: Remove source code block
Pikchr--xDocs: Deleted (19 lines)
Note over Docs: Keep SVG reference intact
Dev->>Docs: Update file (line 213)
Docs->>SVG: Reference: 
Reader->>Docs: View documentation
Docs->>SVG: Load diagram
SVG->>Reader: Display observable flow diagram
Note over Reader: Cleaner docs, same visual result
|
Contributor
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
Contributor
Author
|
Fixed by #940 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.