Skip to content

Comments

Fix #390 - Error for opaque enum with base type#391

Merged
dlang-bot merged 1 commit intodlang-community:masterfrom
MoonlightSentinel:opaque-enum
Apr 27, 2020
Merged

Fix #390 - Error for opaque enum with base type#391
dlang-bot merged 1 commit intodlang-community:masterfrom
MoonlightSentinel:opaque-enum

Conversation

@MoonlightSentinel
Copy link
Contributor

: can never appear after ;, only before.

`:` can never appear after `;`, only before.
@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #391 into master will increase coverage by 0.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   75.28%   76.09%   +0.80%     
==========================================
  Files           8        9       +1     
  Lines        6923     7123     +200     
==========================================
+ Hits         5212     5420     +208     
+ Misses       1711     1703       -8     
Impacted Files Coverage Δ
src/dparse/parser.d 90.93% <100.00%> (-0.08%) ⬇️
src/dparse/lexer.d 83.40% <0.00%> (-1.26%) ⬇️
src/dparse/ast.d 52.03% <0.00%> (ø)
src/std/experimental/lexer.d 84.78% <0.00%> (ø)
src/dparse/trivia.d 99.40% <0.00%> (ø)
src/dparse/rollback_allocator.d 91.02% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63559db...538c6af. Read the comment docs.

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@dlang-bot dlang-bot merged commit 828783a into dlang-community:master Apr 27, 2020
@MoonlightSentinel MoonlightSentinel deleted the opaque-enum branch May 4, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants