Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Add publictests test checker to druntime (reboot of #2087)#3069

Merged
dlang-bot merged 3 commits intodlang:masterfrom
MoonlightSentinel:pr/2087
Jul 7, 2020
Merged

Add publictests test checker to druntime (reboot of #2087)#3069
dlang-bot merged 3 commits intodlang:masterfrom
MoonlightSentinel:pr/2087

Conversation

@MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Apr 26, 2020

name: Run @betterC tests
- run:
command: ./.circleci/run.sh publictests
name: Run public unittests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as an FYI this won't apply to all existing PRs. They need to be rebased for them to have this test.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!!!

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3069"

They are not included in the docs but still extracted by test_extractor.d
@MoonlightSentinel
Copy link
Contributor Author

Rebased to retrigger the CI

@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented Jul 7, 2020

Not sure why Win32 reliably fails on Azure & auto-tester as this doesn't touch windows specific stuff. Anybody got an idea?

@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented Jul 7, 2020

Nevermind, it's an Optlink error that opens a dialog ...

Unexpected OPTLINK Termination at EIP=004211CB

EDIT: Apparently triggered by 202a46c

MoonlightSentinel and others added 2 commits July 7, 2020 02:25
Verifies that every public unittests can be executed as standalone on
dlang.org and doesn't rely e.g. on imports outside of the unittests block.
@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented Jul 7, 2020

Using fabs instead of an explicit expressions seems to work.

Ping @wilzbach

@dlang-bot dlang-bot merged commit d29f5cf into dlang:master Jul 7, 2020
@MoonlightSentinel MoonlightSentinel deleted the pr/2087 branch July 7, 2020 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants