Fix #397 - extern(C++, ...) only supports identifiers#398
Merged
dlang-bot merged 1 commit intodlang-community:masterfrom May 2, 2020
Merged
Fix #397 - extern(C++, ...) only supports identifiers#398dlang-bot merged 1 commit intodlang-community:masterfrom
dlang-bot merged 1 commit intodlang-community:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 76.12% 76.26% +0.14%
==========================================
Files 9 9
Lines 7132 7168 +36
==========================================
+ Hits 5429 5467 +38
+ Misses 1703 1701 -2
Continue to review full report at Codecov.
|
MoonlightSentinel
force-pushed
the
string-ns
branch
8 times, most recently
from
abb90e2 to
28f4d4e
Compare
Implemented according to the grammar defined in the pending spec PR 2716
MoonlightSentinel
force-pushed
the
string-ns
branch
from
28f4d4e to
914ff96
Compare
8 tasks
Geod24
approved these changes
May 2, 2020
Member
Geod24
left a comment
Geod24
left a comment
There was a problem hiding this comment.
LGTM, but I have no power here.
WebFreak001
approved these changes
May 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented according to the grammar defined in the pending spec PR