Conversation
They cause a lot of warnings when using DParse-based tools (DScanner/test_extractor/...)
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3087" |
| enum EHOSTDOWN = 147 /** Host is down */; | ||
| enum EHOSTUNREACH = 148 /** No route to host */; | ||
| enum EWOULDBLOCK = EAGAIN; /** Resource temporarily unavailable */; | ||
| enum EWOULDBLOCK = EAGAIN /** Resource temporarily unavailable */; |
There was a problem hiding this comment.
That's a weird wait to document symbol though. 👍 for making it consistent, but does it even work ?
There was a problem hiding this comment.
That stood out to me too, but I think fix in a separate PR.
There was a problem hiding this comment.
No, those comments need to be after the semicolon but thats for another PR
There was a problem hiding this comment.
I don't know if those DDocs are used, that's in version(Solaris). Probably it was that way in the original.
|
buildkite/dub failure is (obviously) unrelated |
|
All buildkite jobs are going to fail with this unrelated failure. Long story short, code.dlang.org starts forgetting versions after 100 tags are present. See for more details: dlang/dub-registry#458 |
They cause a lot of warnings when using DParse-based tools (DScanner/test_extractor/...) which needlessly clutter the log files (e.g. in #3069 )