Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Remove superflous semicolons#3087

Merged
schveiguy merged 1 commit intodlang:masterfrom
MoonlightSentinel:cleanup
May 1, 2020
Merged

Remove superflous semicolons#3087
schveiguy merged 1 commit intodlang:masterfrom
MoonlightSentinel:cleanup

Conversation

@MoonlightSentinel
Copy link
Contributor

They cause a lot of warnings when using DParse-based tools (DScanner/test_extractor/...) which needlessly clutter the log files (e.g. in #3069 )

They cause a lot of warnings when using DParse-based tools
(DScanner/test_extractor/...)
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3087"

Copy link
Member

@schveiguy schveiguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the auto tester passes, I think this should be committed. Adding auto-merge, as this is the kind of PR that will get quickly out of date. Nevermind, Nick already did it.

enum EHOSTDOWN = 147 /** Host is down */;
enum EHOSTUNREACH = 148 /** No route to host */;
enum EWOULDBLOCK = EAGAIN; /** Resource temporarily unavailable */;
enum EWOULDBLOCK = EAGAIN /** Resource temporarily unavailable */;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a weird wait to document symbol though. 👍 for making it consistent, but does it even work ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That stood out to me too, but I think fix in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, those comments need to be after the semicolon but thats for another PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if those DDocs are used, that's in version(Solaris). Probably it was that way in the original.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #3088

@MoonlightSentinel
Copy link
Contributor Author

buildkite/dub failure is (obviously) unrelated

@schveiguy
Copy link
Member

All buildkite jobs are going to fail with this unrelated failure. Long story short, code.dlang.org starts forgetting versions after 100 tags are present. See for more details: dlang/dub-registry#458

@schveiguy schveiguy merged commit a4ee141 into dlang:master May 1, 2020
@MoonlightSentinel MoonlightSentinel deleted the cleanup branch May 1, 2020 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants