Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Fix DDOC comments in core/stdc/errno.d#3088

Merged
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:cleanup
May 2, 2020
Merged

Fix DDOC comments in core/stdc/errno.d#3088
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:cleanup

Conversation

@MoonlightSentinel
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3088"

Copy link
Member

@schveiguy schveiguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell from the diff whether the comments all were preserved, but I'm not going to worry about it.

@MoonlightSentinel
Copy link
Contributor Author

I used regex search+replace so there should be no issues here

@schveiguy
Copy link
Member

I'd like to merge this, but the circleci build seems to have a spurious failure.

@dlang-bot dlang-bot merged commit c076b6d into dlang:master May 2, 2020
@Geod24
Copy link
Member

Geod24 commented May 2, 2020

@schveiguy : Retriggered the CI for you. You should be able to do it from CircleCI interface though.

@schveiguy
Copy link
Member

schveiguy commented May 2, 2020

I looked, but even though it said I was logged in, it didn't give me options to retry.

Edit: just went in again, I must have been logged in some other way, because I logged out and back in and now I see the rerun button.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants