Remove unused code from test_extractor.d#403
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jun 25, 2020
Merged
Conversation
MoonlightSentinel
force-pushed
the
simplify
branch
from
ade1498 to
ec03501
Compare
8 tasks
Member
|
Nice! |
Geod24
added
the
PR.Blocked
`hasDdocHeader` was only called if `decl.unittest_` wasn't null and hence only executed the first if-branch. The remainder of that method is obsolete because dparse sets `comment` even for empty ddoc comments (see dlang-community/libdparse#401). Relying on dparse also removes some false positives/negatives, e.g. ``` /// // Some comment unittest {} // Ignored //////////////////////////////////////////////////////////////////////////////// // Unit Tests //////////////////////////////////////////////////////////////////////////////// unittest {} // Extracted ```
MoonlightSentinel
force-pushed
the
simplify
branch
from
ec03501 to
355e5cd
Compare
MoonlightSentinel
removed
the
PR.Blocked
Contributor
Author
|
Finally ready |
thewilsonator
approved these changes
Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hasDdocHeaderwas only called ifdecl.unittest_wasn't null andhence only executed the first if-branch.
The remainder of that method is obsolete because dparse sets
commenteven for empty ddoc comments (see dlang-community/libdparse#401).
Relying on dparse also removes some false positives/negatives, e.g.
Note: This can be merged once dparse tags a new release containing the aforementioned PR.