Handle empty doc comments ("///") on unittests#401
Merged
dlang-bot merged 3 commits intodlang-community:masterfrom May 4, 2020
Merged
Handle empty doc comments ("///") on unittests#401dlang-bot merged 3 commits intodlang-community:masterfrom
dlang-bot merged 3 commits intodlang-community:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 76.28% 76.43% +0.15%
==========================================
Files 9 9
Lines 7172 7224 +52
==========================================
+ Hits 5471 5522 +51
- Misses 1701 1702 +1
Continue to review full report at Codecov.
|
WebFreak001
approved these changes
May 3, 2020
MoonlightSentinel
added a commit
to MoonlightSentinel/tools
that referenced
this pull request
May 3, 2020
`hasDdocHeader` was only called if decl.unittest_ wasn't null and hence only executed the first if-branch. The remainder of that method is obsolete because dparse sets `comment` even for empty ddoc comments (see dlang-community/libdparse#401).
MoonlightSentinel
added a commit
to MoonlightSentinel/tools
that referenced
this pull request
May 3, 2020
`hasDdocHeader` was only called if `decl.unittest_` wasn't null and hence only executed the first if-branch. The remainder of that method is obsolete because dparse sets `comment` even for empty ddoc comments (see dlang-community/libdparse#401). Relying on dparse also removes some false positives/negatives, e.g. ``` /// // Some comment unittest {} // Ignored //////////////////////////////////////////////////////////////////////////////// // Unit Tests //////////////////////////////////////////////////////////////////////////////// unittest {} // Extracted ```
MoonlightSentinel
added a commit
to MoonlightSentinel/tools
that referenced
this pull request
May 3, 2020
`hasDdocHeader` was only called if `decl.unittest_` wasn't null and hence only executed the first if-branch. The remainder of that method is obsolete because dparse sets `comment` even for empty ddoc comments (see dlang-community/libdparse#401). Relying on dparse also removes some false positives/negatives, e.g. ``` /// // Some comment unittest {} // Ignored //////////////////////////////////////////////////////////////////////////////// // Unit Tests //////////////////////////////////////////////////////////////////////////////// unittest {} // Extracted ```
8 tasks
MoonlightSentinel
added a commit
to MoonlightSentinel/tools
that referenced
this pull request
Jun 24, 2020
`hasDdocHeader` was only called if `decl.unittest_` wasn't null and hence only executed the first if-branch. The remainder of that method is obsolete because dparse sets `comment` even for empty ddoc comments (see dlang-community/libdparse#401). Relying on dparse also removes some false positives/negatives, e.g. ``` /// // Some comment unittest {} // Ignored //////////////////////////////////////////////////////////////////////////////// // Unit Tests //////////////////////////////////////////////////////////////////////////////// unittest {} // Extracted ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no way to differentiate between the following unittests because
unittest.commentisnullfor both:This PR ensures that
commentis non-nullif a declaration has an empty doc comment.