Fix #53 - Support GDC extended asm syntax#404
Merged
dlang-bot merged 8 commits intodlang-community:masterfrom May 18, 2020
Merged
Fix #53 - Support GDC extended asm syntax#404dlang-bot merged 8 commits intodlang-community:masterfrom
dlang-bot merged 8 commits intodlang-community:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
+ Coverage 76.44% 78.58% +2.14%
==========================================
Files 9 9
Lines 7225 7382 +157
==========================================
+ Hits 5523 5801 +278
+ Misses 1702 1581 -121
Continue to review full report at Codecov.
|
MoonlightSentinel
force-pushed
the
gcc-asm
branch
2 times, most recently
from
cd253ae to
d24838b
Compare
8 tasks
Collaborator
|
Sorry for the delay. I haven't forgotten about this. |
Contributor
Author
|
Don't worry about it, this just removes a lot of error messages from druntime and isn't blocking other work. |
Hackerpilot
reviewed
May 17, 2020
Hackerpilot
reviewed
May 17, 2020
Hackerpilot
reviewed
May 17, 2020
Hackerpilot
reviewed
May 17, 2020
Hackerpilot
reviewed
May 17, 2020
Hackerpilot
reviewed
May 17, 2020
Hackerpilot
requested changes
May 17, 2020
Collaborator
Hackerpilot
left a comment
Hackerpilot
left a comment
There was a problem hiding this comment.
Done reviewing for now. I should be able to answer questions with much lower latency than in the last few weeks.
Hackerpilot
approved these changes
May 18, 2020
Contributor
Author
|
Thanks. A new release would be appreciated (once it's ready) |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should already work for all "pure" GCC style
asm-statements but probably needs to be revised against gdc (which is more permissive in certain aspects). Mostly looking for feedback regarding the generated AST.WIP because this still needs some cleanup and mabye more test coverage.TODO: