Apply taggedalgebraic PR 61 by copypaste-inlining taggedalgebraic#51
Closed
FeepingCreature wants to merge 3 commits intodlang-community:masterfrom
Closed
Apply taggedalgebraic PR 61 by copypaste-inlining taggedalgebraic#51FeepingCreature wants to merge 3 commits intodlang-community:masterfrom
FeepingCreature wants to merge 3 commits intodlang-community:masterfrom
Conversation
Prevents a linker error involving @safe inference in opEquals; see https://issues.dlang.org/show_bug.cgi?id=21257 .
Author
|
Added a version requirement for |
Author
|
Retracting this PR. I can no longer reproduce my fix. Somehow, currently I am getting a linker error in |
FeepingCreature
added a commit
to funkwerk/serialized
that referenced
this pull request
Sep 24, 2020
Revert this commit once dlang-community/std_data_json#51 or s-ludwig/taggedalgebraic#61 are merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since s-ludwig/taggedalgebraic#61 hasn't gotten replies and is holding us up via DMD bug https://issues.dlang.org/show_bug.cgi?id=21257 , sidestep the issue by temporarily inlining taggedalgebraic with the fix applied.
This commit should be reverted once PR 61 is merged.
I'd normally advocate fixing 21257 instead, but it's beyond me, so we'd be dependent on luck wrt getting a maintainer to look at it.
Note this is taggedalgebraic master - why were we rejecting 0.12.0 to begin with?