Copypaste-inline taggedalgebraic, try 2. Fixes #41?#52
Copypaste-inline taggedalgebraic, try 2. Fixes #41?#52FeepingCreature wants to merge 3 commits intodlang-community:masterfrom
Conversation
…bug.cgi?id=21257 ) Remove templated opEquals from taggedalgebraic and replace with template-free version that only works for std_data_json.
|
Commits f0749c8 and b85fa6b look good to me (though please update the commit message of f0749c8 to specify the exact git hash of taggedalgebraic you're inlining) but 43496db worries me as it deletes many unit tests. Do all of them need to disabled? Can you at least mark them with |
|
That's deliberate. taggedalgebraic has a lot more functionality than std.data.json needs, and those unittests check for it. I just chucked everything out that triggered errors and didn't seem to be the sort of type that |
|
I've just run into the bug. Can we go forward with this? |
|
Is this still necessary? Can this be fixed in taggedalgebraic directly instead? |
|
Feel free to close if you don't want it- as mentioned, I'm using an inlined fork of std.data.json anyways. |
Backport of the taggedalgebraic hacks I've done in serialized to sidestep DMD bug https://issues.dlang.org/show_bug.cgi?id=21235 .
This is an update of #51 , this time with a backported version of
std_data_jsonthat has actually been tested and actually avoids the linker error from #41 .Note that these changes can never be upstreamed to
taggedalgebraic, because they breakopEqualsso that it only barely even works for ourJSONValue.This should be safe to revert once the DMD bug is fixed, but I wouldn't count on this happening soon: from what I've seen of it, it's an ugly one, and happens rarely to boot.