Temporarily patch Ocean to workaround missing out contract patch#115
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jan 7, 2018
Merged
Temporarily patch Ocean to workaround missing out contract patch#115dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Collaborator
|
Thanks for your pull request, @wilzbach! |
Contributor
Author
|
See also: #112 CC @mihails-strasuns-sociomantic as looking at: https://github.com/sociomantic-tsunami/ocean/blob/v4.0.0-alpha.4/src/ocean/net/http/HttpResponse.d#L466 still shows the bogus contract. |
Contributor
Author
|
The git commit sha checked out is the same: |
Contributor
|
Beg my pardon - I have forgot to make a point release with the fix before propagating changes to v4.x.x, thus it wasn't present. Will fix in a moment. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch applied in sociomantic-tsunami/ocean#427
doesn't seem to appear in Ocean
v4.0.0-alpha.4anymore.Currently it fails:
dlang/dmd#7617
However, Jenkins did pass on
dlang/dmd#7553 and e.g. on
dlang/phobos#6002