Skip to content

Comments

Issue 15157: Adjust building blocks docs#6002

Merged
dlang-bot merged 1 commit intodlang:masterfrom
jmh530:patch-2
Jan 6, 2018
Merged

Issue 15157: Adjust building blocks docs#6002
dlang-bot merged 1 commit intodlang:masterfrom
jmh530:patch-2

Conversation

@jmh530
Copy link
Contributor

@jmh530 jmh530 commented Jan 5, 2018

No description provided.

@quickfur quickfur added the Review:Trivial typos, formatting, comments label Jan 5, 2018
Copy link
Member

@quickfur quickfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 6, 2018

Thanks for your pull request, @jmh530! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
15157 std.experimental.allocator.building_blocks docs

@wilzbach
Copy link
Contributor

wilzbach commented Jan 6, 2018

(rebased to upstream/master to fix the CI failures)

@wilzbach
Copy link
Contributor

wilzbach commented Jan 6, 2018

I just noticed the following:

image

As explained here:

A means that the issue is only mentioned (i.e. the commit message doesn't contain "Fix") and the Bugzilla issue won't be auto-closed nor listed in the changelog as fixed:

-> I prefixed the commit title with "Fix "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants