Fix #119 - Don't edit the Bot's comment if the PR has been closed/merged#121
Merged
wilzbach merged 2 commits intodlang:masterfrom Jul 16, 2017
Merged
Fix #119 - Don't edit the Bot's comment if the PR has been closed/merged#121wilzbach merged 2 commits intodlang:masterfrom
wilzbach merged 2 commits intodlang:masterfrom
Conversation
Collaborator
|
Thanks for your pull request, @wilzbach! |
…ately tried on a synchronize event)
MartinNowak
reviewed
Jul 16, 2017
| commits = pr.tryMerge(method); | ||
| return; | ||
| } | ||
| if (action == "synchronize") |
Member
There was a problem hiding this comment.
Looks a bit as if action == "synchronize" was added later, anyhow thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered a small issue during this (see the second commit - the bot previously tried to send an auto-merge immediately on a synchronize event. We never noticed this because luckily the GH required checks prevented this form becoming an issue)