Cherry-picking commits to stable: 17650 + CODEOWNERS#5615
Cherry-picking commits to stable: 17650 + CODEOWNERS#5615dlang-bot merged 4 commits intodlang:stablefrom
Conversation
According to the GitHub support: We currently have a bug with CODEOWNERS files where commenting out a line will stop the feature working entirely. If you remove any lines with a # it should start to work correctly again. Alternatively - since you have a lot of commented out lines in that file - you can add a space after the # characters which should also fix the issue.
|
Ping @MartinNowak. Might have to delay the release again. |
FYI:
I realized that not many people are aware of the boards: |
|
Thanks for the Trello invite @wilzbach |
|
@wilzbach Thanks for cherry-picking #5612. In the initial response to the bug Martin indicated a preference for waiting until the first point release. I assumed stable would the initial release, not the first point release. However, I should have at least put a note in the PR asking about the issue, and suggesting the fix may be important enough for the initial release. |
|
Seb, why did the bot not show the warning on #5612? |
It did originally. I see it in the email. Maybe it removed the warning when merging? |
Yep :) So the bot shouldn't overwrite his comment in the future after a merge. |
No worries, we/I just try to make |
|
Already tagged a release candidate yesterday, so this will be released a week later or so when we've fixed the other open regressions. |
#5612 should have been targeted at stable.
Also at #5614 I realized the CODEOWNERS file isn't part of
stableand will take quite a long time to get be merged back intostableagain, so I cherry-picked this as well while I was at it.Note that due to the GH bugs in the CODEOWNERS implementation it took us three PRS to achieve a working CODEOWNERS file.