Skip to content

Cherry-picking commits to stable: 17650 + CODEOWNERS#5615

Merged
dlang-bot merged 4 commits intodlang:stablefrom
wilzbach:cherry-pick-stable
Jul 16, 2017
Merged

Cherry-picking commits to stable: 17650 + CODEOWNERS#5615
dlang-bot merged 4 commits intodlang:stablefrom
wilzbach:cherry-pick-stable

Conversation

@wilzbach
Copy link
Contributor

#5612 should have been targeted at stable.

Also at #5614 I realized the CODEOWNERS file isn't part of stable and will take quite a long time to get be merged back into stable again, so I cherry-picked this as well while I was at it.

Note that due to the GH bugs in the CODEOWNERS implementation it took us three PRS to achieve a working CODEOWNERS file.

jondegenhardt and others added 4 commits July 16, 2017 01:28
According to the GitHub support:
We currently have a bug with CODEOWNERS files where commenting out a line
will stop the feature working entirely.
If you remove any lines with a # it should start to work correctly again.
Alternatively - since you have a lot of commented out lines in that file -
you can add a space after the # characters which should also fix the issue.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Description
17650 [REG v2.075.0 b1-b4] std.getopt range violation

@JackStouffer
Copy link
Contributor

Ping @MartinNowak. Might have to delay the release again.

@wilzbach
Copy link
Contributor Author

Ping @MartinNowak. Might have to delay the release again.

FYI:

I realized that not many people are aware of the boards:

@JackStouffer
Copy link
Contributor

Thanks for the Trello invite @wilzbach

@jondegenhardt
Copy link
Contributor

@wilzbach Thanks for cherry-picking #5612. In the initial response to the bug Martin indicated a preference for waiting until the first point release. I assumed stable would the initial release, not the first point release. However, I should have at least put a note in the PR asking about the issue, and suggesting the fix may be important enough for the initial release.

@dlang-bot dlang-bot merged commit 50dd33c into dlang:stable Jul 16, 2017
@CyberShadow
Copy link
Member

Seb, why did the bot not show the warning on #5612?

@aG0aep6G
Copy link
Contributor

Seb, why did the bot not show the warning on #5612?

It did originally. I see it in the email. Maybe it removed the warning when merging?

@wilzbach
Copy link
Contributor Author

Maybe it removed the warning when merging?

Yep :)
But as I also noticed this I merged the pending PR to fix this behavior:

dlang/dlang-bot#121

So the bot shouldn't overwrite his comment in the future after a merge.

@wilzbach
Copy link
Contributor Author

@wilzbach Thanks for cherry-picking #5612. In the initial response to the bug Martin indicated a preference for waiting until the first point release.

No worries, we/I just try to make stable what it is supposed to be and I think Martin wanted wait for the first point release because he assumed it would take us days to fix this and not a couple of hours with your ultra fast fix 😉
So thanks a lot for finding and fixing this!

@MartinNowak
Copy link
Member

Already tagged a release candidate yesterday, so this will be released a week later or so when we've fixed the other open regressions.

@wilzbach wilzbach deleted the cherry-pick-stable branch December 11, 2017 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants