Move GitHub API code to separate module#85
Merged
PetarKirov merged 2 commits intodlang:masterfrom Jun 25, 2017
Merged
Conversation
Collaborator
|
Thanks for your pull request, @wilzbach! |
wilzbach
force-pushed
the
move-to-api
branch
2 times, most recently
from
6fbbee1 to
742bf18
Compare
Contributor
Author
|
(I will wait with this until all other work is in to avoid repeatedly rebasing) |
Member
|
Time for a rebase? :P |
Contributor
Author
Hehe - done ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The short-term goal is to separate the code logic from the API, s.t. we can add a caching layer inbetween. Of course, an alternative to caching would be https://github.com/CyberShadow/GHDaemon.
The long-term goal is to create a reusable Dub package out of it.