Skip to content

Don't send the CONTRIBUTING advice to public members#87

Merged
wilzbach merged 2 commits intodlang:masterfrom
wilzbach:ignore-members
Jun 23, 2017
Merged

Don't send the CONTRIBUTING advice to public members#87
wilzbach merged 2 commits intodlang:masterfrom
wilzbach:ignore-members

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jun 23, 2017

I explicitly didn't want to hard code information as

  • the bot could in theory be used for any repo (it's e.g. used here as well)
  • hard-coded information gets outdated quickly
  • I wanted to add caching to the API methods soon anyways (e.g. Move GitHub API code to separate module #85)

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some things that can help to speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

@CyberShadow
Copy link
Member

Awesome, thanks!

@wilzbach
Copy link
Contributor Author

Awesome, thanks!

You are very welcome. Not sure how we should proceed here though. Martin is currently busy and there's no other reviewer around).

@wilzbach
Copy link
Contributor Author

Up to you. I don't think it's urgent unless someone finds it annoying.

Let's be nice to Walter & Co - I don't want the hello world messages to leave a bad, first impression.

@wilzbach wilzbach merged commit a2bf916 into dlang:master Jun 23, 2017
@wilzbach wilzbach deleted the ignore-members branch June 23, 2017 08:18
@dnadlinger
Copy link

+1, feel free to retroactively direct any blame my way. ;P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants