Fix Issue 17644 - [Downloads] Bad link to changelog for DMD beta version#1820
Fix Issue 17644 - [Downloads] Bad link to changelog for DMD beta version#1820wilzbach wants to merge 2 commits intodlang:masterfrom
Conversation
wilzbach
changed the title
|
Link for Beta is okay now, but for Nightly there is a link to changelog/<!--UNDEFINED MACRO:. Maybe $(NIGHTLIES_DMDV2) ? |
| $(DIVC download_channel, | ||
| $(H2 $(LNAME2 dmd-nightly,DMD Nightly)) | ||
| $(H2 $(LNAME2 dmd-nightly,DMD Nightly ($(NIGHTLIES_DMDV2)))) | ||
| $(LINK2 changelog/$(NIGHTLIES_DMDV2)_pre.html, Changelog) |
There was a problem hiding this comment.
Should be _pending here
There was a problem hiding this comment.
Cause there are days where I am traveling and can only do stuff on my phone ;-)
There was a problem hiding this comment.
Want me to fix that for you then?
There was a problem hiding this comment.
If you think it's critical, feel free to go ahead. Otherwise I can get to it tomorrow.
Thanks, but I can't see this on DAutoTest (click on details at the CI). If you tried this locally, you need to nuke |
|
"nuke generated"? Hmm, CONTRIBUTING.md seems inadequate. See also https://issues.dlang.org/show_bug.cgi?id=17649. Anyway the download page generated by DAutoTest looks good, so original bug can be closed. Thanks. |
MartinNowak
left a comment
MartinNowak
left a comment
There was a problem hiding this comment.
That doesn't look like the right solution for the beta changelog, adding a link to the pending nightly changelog seems fine, but they also shouldn't be under _pre.html maybe.
| $(DIVC download_channel, | ||
| $(H2 $(LNAME2 dmd_beta,DMD Beta $(B_DMDV2)-$(B_SUFFIX))) | ||
| $(LINK2 changelog/$(B_DMDV2).html, Changelog) | ||
| $(LINK2 changelog/$(B_DMDV2)_pre.html, Changelog) |
There was a problem hiding this comment.
So far we made the beta changelog from 2.075.0_pre.dd to 2.075.0.html, something went wrong to make a _pre.html from a (generated?) _pre.dd changelog instead.
|
Ah apparently this was changed/broken with #1817. What's the point of the |
|
This is superfluous with the new changes to the changelog, e.g. |
4 participants
No description provided.